Skip to content

rmse was wrongly calculated #9771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rmse was wrongly calculated #9771

wants to merge 1 commit into from

Conversation

vivkul
Copy link

@vivkul vivkul commented Nov 17, 2015

It was multiplying with U instaed of dividing by U

rmse was wrongly calculated
4cee53c 
It was multiplying with U instaed of dividing by U
@srowen
Copy link
Member

srowen commented Nov 17, 2015

LGTM. This is on the border of needing a JIRA IMHO.
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #2081 has finished for PR 9771 at commit 4cee53c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Nov 18, 2015
@srowen
rmse was wrongly calculated
48bfe3f 
It was multiplying with U instaed of dividing by U

Author: Viveka Kulharia <vivkul@iitk.ac.in>

Closes #9771 from vivkul/patch-1.

(cherry picked from commit 1429e0a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit pushed a commit that referenced this pull request Nov 18, 2015
@srowen
rmse was wrongly calculated
4b8dc25 
It was multiplying with U instaed of dividing by U

Author: Viveka Kulharia <vivkul@iitk.ac.in>

Closes #9771 from vivkul/patch-1.

(cherry picked from commit 1429e0a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit pushed a commit that referenced this pull request Nov 18, 2015
@srowen
rmse was wrongly calculated
e12fbd8 
It was multiplying with U instaed of dividing by U

Author: Viveka Kulharia <vivkul@iitk.ac.in>

Closes #9771 from vivkul/patch-1.

(cherry picked from commit 1429e0a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Nov 18, 2015

Merged to master/1.6/1.5/1.4

@asfgit asfgit closed this in 1429e0a Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivkul @srowen @SparkQA