Skip to content

[SPARK-9928][SQL] Removal of LogicalLocalTable #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

gatorsmile
Copy link
Member

LogicalLocalTable in ExistingRDD.scala is replaced by localRelation in LocalRelation.scala?

Do you know any reason why we still keep this class?

@SparkQA
Copy link

SparkQA commented Nov 14, 2015

Test build #45933 has finished for PR 9717 at commit 195d176.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

The failure of this test case is not related to the code changes. It sounds like the other PR also hit the same issue.

For example, in #9642, the same failure:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45853/consoleFull

@gatorsmile
Copy link
Member Author

Anybody can help me trigger the retest, please?

@gatorsmile
Copy link
Member Author

@srowen Could you review the changes? Thanks!

@SparkQA
Copy link

SparkQA commented Nov 14, 2015

Test build #45935 has finished for PR 9717 at commit 195d176.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Another case failed due to the same reasons. This is not related to the code changes made in this PR.

java.lang.IllegalStateException: Cannot call methods on a stopped SparkContext.

Timing issues? Or introduced by a recent merge?

@cloud-fan
Copy link
Contributor

retest this please.

@cloud-fan
Copy link
Contributor

the tests are quite flaky now, we are fixing it.

@SparkQA
Copy link

SparkQA commented Nov 16, 2015

Test build #45969 has finished for PR 9717 at commit 195d176.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM cc @yhuai

@yhuai
Copy link
Contributor

yhuai commented Nov 16, 2015

Merging to master and branch 1.6.

asfgit pushed a commit that referenced this pull request Nov 16, 2015
LogicalLocalTable in ExistingRDD.scala is replaced by localRelation in LocalRelation.scala?

Do you know any reason why we still keep this class?

Author: gatorsmile <gatorsmile@gmail.com>

Closes #9717 from gatorsmile/LogicalLocalTable.

(cherry picked from commit b58765c)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@asfgit asfgit closed this in b58765c Nov 16, 2015
@gatorsmile
Copy link
Member Author

Thanks!

@gatorsmile gatorsmile deleted the LogicalLocalTable branch December 7, 2015 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants