[SPARK-11672] [ML] Set active SQLContext in MLlibTestSparkContext.beforeAll #9694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,8 +48,11 @@ private[util] sealed trait BaseReadWrite { | |||
| /** | |||
| * Returns the user-specified SQL context or the default. | |||
| */ | |||
| protected final def sqlContext: SQLContext = optionSQLContext.getOrElse { | |||
| SQLContext.getOrCreate(SparkContext.getOrCreate()) | |||
There was a problem hiding this comment.
Seems we still need to use getOrCreate? Otherwise, we will keep creating new sqlContexts. Also, if we actually use HiveContext, without using getOrCreate, we will not be able to get that.
There was a problem hiding this comment.
This is just a workaround for the issue. User can use .context(hiveContext) to specify a context to use.
|
Test build #45868 has finished for PR 9694 at commit
|
mengxr
changed the title
|
Test build #45887 has finished for PR 9694 at commit
|
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2015
…reAll Still saw some error messages caused by `SQLContext.getOrCreate`: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/3997/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.3,label=spark-test/testReport/junit/org.apache.spark.ml.util/JavaDefaultReadWriteSuite/testDefaultReadWrite/ This PR sets the active SQLContext in beforeAll, which is not automatically set in `new SQLContext`. This makes `SQLContext.getOrCreate` return the right SQLContext. cc: yhuai Author: Xiangrui Meng <meng@databricks.com> Closes #9694 from mengxr/SPARK-11672.3. (cherry picked from commit 2d2411f) Signed-off-by: Xiangrui Meng <meng@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2015
The same as #9694, but for Java test suite. yhuai Author: Xiangrui Meng <meng@databricks.com> Closes #9719 from mengxr/SPARK-11672.4. (cherry picked from commit 64e5551) Signed-off-by: Yin Huai <yhuai@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2015
The same as #9694, but for Java test suite. yhuai Author: Xiangrui Meng <meng@databricks.com> Closes #9719 from mengxr/SPARK-11672.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still saw some error messages caused by
SQLContext.getOrCreate:https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/3997/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.3,label=spark-test/testReport/junit/org.apache.spark.ml.util/JavaDefaultReadWriteSuite/testDefaultReadWrite/
This PR sets the active SQLContext in beforeAll, which is not automatically set in
new SQLContext. This makesSQLContext.getOrCreatereturn the right SQLContext.cc: @yhuai