[SPARK-11595] [SQL] [BRANCH-1.5] Fixes ADD JAR when the input path contains URL scheme #9570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #45372 has finished for PR 9570 at commit
|
|
Test build #2022 has finished for PR 9570 at commit
|
|
Is the failed test a legitimate one? |
|
Test build #45639 has finished for PR 9570 at commit
|
|
Let's add this test in thfitserver tests. |
| val jarPath = TestHive.getHiveFile("TestUDTF.jar").getCanonicalPath | ||
|
|
||
| // SPARK-11595 Fixes ADD JAR when input path contains URL scheme | ||
| val jarURL = s"file://$jarPath" |
There was a problem hiding this comment.
Should we also check a URL without a scheme?
There was a problem hiding this comment.
Is it possible to remove an added jar? I'm afraid if we add the other test case, these two may interfere with each other.
There was a problem hiding this comment.
Actually there are other test cases that already covered the case without a scheme. So I think it's fine.
|
Thanks! Merging to branch 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2015
…ains URL scheme This PR backports #9569 to branch-1.5. Author: Cheng Lian <lian@databricks.com> Closes #9570 from liancheng/spark-11595.for-branch-1.5.
|
I have merged it to branch 1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #9569 to branch-1.5.