[SPARK-10740][SQL] handle nondeterministic expressions correctly for set operations #8858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #42794 has finished for PR 8858 at commit
|
cloud-fan
force-pushed
the
non-deter
branch
from
a1f41b5 to
555cf3b
Compare
|
Test build #42799 has finished for PR 8858 at commit
|
| def expected(df: DataFrame): Seq[Row] = { | ||
| df.rdd.collectPartitions().zipWithIndex.flatMap { | ||
| case (data, index) => | ||
| val rng = new org.apache.spark.util.random.XORShiftRandom(7 + index) |
There was a problem hiding this comment.
It will be good to have a comment to say we need to match the behavior of RAND when generating expected results.
|
LGTM. Merging to master and branch 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Sep 22, 2015
… set operations https://issues.apache.org/jira/browse/SPARK-10740 Author: Wenchen Fan <cloud0fan@163.com> Closes #8858 from cloud-fan/non-deter. (cherry picked from commit 5017c68) Signed-off-by: Yin Huai <yhuai@databricks.com>
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
… set operations https://issues.apache.org/jira/browse/SPARK-10740 Author: Wenchen Fan <cloud0fan@163.com> Closes apache#8858 from cloud-fan/non-deter. (cherry picked from commit 5017c68) Signed-off-by: Yin Huai <yhuai@databricks.com> (cherry picked from commit 54334d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-10740