Skip to content

[SPARK-10495] [SQL] Read date values in JSON data stored by Spark 1.5.0. #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-10495] [SQL] Read date values in JSON data stored by Spark 1.5.0. #8806

wants to merge 2 commits into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Sep 18, 2015

@yhuai yhuai changed the title [SPARK-10495] [SQL] Read date values stored in Spark 1.5.0. [SPARK-10495] [SQL] Read date values in JSON data stored by Spark 1.5.0. Sep 18, 2015
@SparkQA
Copy link

SparkQA commented Sep 18, 2015

Test build #42630 has finished for PR 8806 at commit 593f2b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class TaskCommitDenied(
    • class Interaction(override val uid: String) extends Transformer
    • final val probabilityCol: Param[String] = new Param[String](this, "probabilityCol", "Column name for predicted class conditional probabilities. Note: Not all models output well-calibrated probability estimates! These probabilities should be treated as confidences, not precise probabilities")
    • s"Failed to convert value $v (class of $
    • s"Failed to convert value $v (class of $
    • abstract class LocalNode(conf: SQLConf) extends QueryPlan[LocalNode] with Logging

liancheng
liancheng reviewed Sep 18, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonGenerator.scala
// For UDT, udt.serialize will produce SQL types. So, we need the following three cases.
case (ArrayType(ty, _), v: ArrayData) =>
gen.writeStartArray()
v.foreach(ty, (_, value) => valWriter(ty, value))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably replace this foreach with a while.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This foreach is provided by ArrayData.

@yhuai
Copy link
Contributor Author

yhuai commented Sep 18, 2015

test this please

@SparkQA
Copy link

SparkQA commented Sep 18, 2015

Test build #1774 has finished for PR 8806 at commit f0505de.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Interaction(override val uid: String) extends Transformer
    • s"Failed to convert value $v (class of $
    • s"Failed to convert value $v (class of $

@SparkQA
Copy link

SparkQA commented Sep 18, 2015

Test build #42687 has finished for PR 8806 at commit f0505de.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s"Failed to convert value $v (class of $
    • s"Failed to convert value $v (class of $

asfgit pushed a commit that referenced this pull request Sep 22, 2015
@yhuai @liancheng
[SPARK-10495] [SQL] Read date values in JSON data stored by Spark 1.5.0.
7ab4d17 
https://issues.apache.org/jira/browse/SPARK-10681

Author: Yin Huai <yhuai@databricks.com>

Closes #8806 from yhuai/SPARK-10495.

(cherry picked from commit 0494c80)
Signed-off-by: Cheng Lian <lian@databricks.com>
@liancheng
Copy link
Contributor

LGTM, merged to master and branch-1.5.

@asfgit asfgit closed this in 0494c80 Sep 22, 2015
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
@yhuai
[SPARK-10495] [SQL] Read date values in JSON data stored by Spark 1.5.0.
425a932 
https://issues.apache.org/jira/browse/SPARK-10681

Author: Yin Huai <yhuai@databricks.com>

Closes apache#8806 from yhuai/SPARK-10495.

(cherry picked from commit 0494c80)
Signed-off-by: Cheng Lian <lian@databricks.com>
(cherry picked from commit 7ab4d17)
@gatorsmile gatorsmile mentioned this pull request Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhuai @SparkQA @liancheng