[SPARK-10300] [BUILD] [TESTS] Add support for test tags in run-tests.py. #8775
Conversation
A new module ("tags/") was added where all test tags should be placed.
This is required because the JUnit runners for both maven and sbt require
the classes to be visible when you disable them, even if no tests actually
reference them.
To avoid a cyclic dependency, the tags dependency needs to be manually added
to all poms, which is annoying. An alternative would be to make the tag
module's pom not have spark-parent as its parent, but that would mean
replicating some information from the parent pom and fixing other code
(such as the "change-scala-version.sh" script).
|
Re-posting previous PR with a fix for the issue that caused tests to fail in other PRs. For the changes since the last PR, see only the second commit. I'm not super happy with needing the new module, but I couldn't find an alternative that still allowed us to tag JUnit tests. The extra noise to add the dependencies to all other poms also irks me a little bit. /cc @pwendell to see if you have a better suggestion... |
|
Test build #42511 has finished for PR 8775 at commit
|
|
Test build #42514 has finished for PR 8775 at commit
|
|
retest this please |
|
any comments on the new approach? |
|
Test build #42844 has finished for PR 8775 at commit
|
|
retest this please |
|
Test build #43062 has finished for PR 8775 at commit
|
|
I'll run the tests once again and push this, since I haven't seen any feedback on top of the previous PR. retest this please |
|
LGTM. Merged into master. Thanks! There might be a small issue with the default value. I will test it locally and send follow-up PR if necessary. |
|
Test build #43279 has finished for PR 8775 at commit
|
|
@mengxr, looks like the merge commit didn't get pushed (or ASF -> Git mirroring is lagging)? |
|
Yes, this was not pushed. I'll push this later if it's still around. |
|
ok merging. |
No description provided.