Skip to content

[SPARK-10198][SQL] Turn off partition verification by default #8404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-10198][SQL] Turn off partition verification by default #8404

wants to merge 3 commits into from

Conversation

marmbrus
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41491 has finished for PR 8404 at commit 7cc6741.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41493 has finished for PR 8404 at commit 5826f16.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jeanlyn
jeanlyn reviewed Aug 25, 2015
View reviewed changes
sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala
val testData = ctx.sparkContext.parallelize(
(1 to 10).map(i => TestData(i, i.toString))).toDF()
testData.registerTempTable("testData")
withSQLConf((SQLConf.HIVE_VERIFY_PARTITION_PATH.key, "false")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be set to true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good catch.

@marmbrus
Copy link
Contributor Author

Failing test passes locally after the config fix. I'm going to merge so this can be included in the next RC.

asfgit pushed a commit that referenced this pull request Aug 25, 2015
@marmbrus
[SPARK-10198] [SQL] Turn off partition verification by default
0402f12 
Author: Michael Armbrust <michael@databricks.com>

Closes #8404 from marmbrus/turnOffPartitionVerification.

(cherry picked from commit 5c08c86)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 5c08c86 Aug 25, 2015
@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41536 has finished for PR 8404 at commit 6a4d6db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

CaptionKid
CaptionKid reviewed Jun 27, 2019
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala
@@ -312,7 +312,7 @@ private[spark] object SQLConf {
doc = "When true, enable filter pushdown for ORC files.")

val HIVE_VERIFY_PARTITION_PATH = booleanConf("spark.sql.hive.verifyPartitionPath",
defaultValue = Some(true),
defaultValue = Some(false),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this place use false as default value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaptionKid CaptionKid CaptionKid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marmbrus @SparkQA @jeanlyn @CaptionKid