[SPARK-9938][SQL]Constant folding of binaryComparison on IntegralType #8165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #40763 has finished for PR 8165 at commit
|
|
@marmbrus @liancheng, Is this PR useful? I'm doing this because #8157 (comment) |
|
Sorry for the late reply. I think it's great to have a general mechanism to check whether we can safely cast type But the constant folding part doesn't seem to be super useful? Especially when it makes the original |
|
:) yes, I also think its a long one.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could get a chance to do constant folding when we are comparing a IntegerType column with Long Literal.
JIRA: https://issues.apache.org/jira/browse/SPARK-9938