[SPARK-4449][Core]Specify port range in spark #8054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -193,7 +187,7 @@ private[spark] object Utils extends Logging { | |||
| } | |||
|
|
|||
| /** | |||
| * Primitive often used when writing [[java.nio.ByteBuffer]] to [[java.io.DataOutput]] | |||
| * Primitive often used when writing java.nio.ByteBuffer to java.io.DataOutput | |||
…rrectly. Made maxPort 65536 to allow the range to be port to 65536. Implemented logic
|
@nssalian can you explain the difference between this and #5722? IIUC this introduces some kind of global port range right? I think our past discussions with @srowen @vanzin and @tgravescs already ruled that solution out. |
| } | ||
| else { | ||
| // If the new port wraps around, do not try a privilege port or a failedPort | ||
| while(!failedPorts.contains((startPort + Math.random() * (maxPort - startPort + 1))) && |
There was a problem hiding this comment.
This is an array buffer, so contains is linear time, which is pretty expensive. Also this code is very difficult to understand.
|
Yes, do you mind closing this PR? this is not quite getting at what needs to happen for SPARK-4449 |
|
Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify port range in spark
JIRA link: https://issues.apache.org/jira/browse/SPARK-4449
Goal: To add a port range to services
Design: (Based on the input and the suggestions in t #3314 and #5722):
Requesting review.