Use vector-friendly comparison for packages argument.#7701
Closed
trestletech wants to merge 3 commits intoapache:masterfrom
Closed
Use vector-friendly comparison for packages argument.#7701trestletech wants to merge 3 commits intoapache:masterfrom
trestletech wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Jenkins, ok to test |
Contributor
|
Thanks @trestletech -- Could you also add a small unit tests for this in https://github.com/apache/spark/blob/15724fac569258d2a149507d8c767d0de0ae8306/R/pkg/inst/tests/test_client.R ? |
Contributor
Author
|
Just added a test. I'll confess that I haven't been able to run the tests due to some missing Spark dev incompatibility, though. |
|
Test build #38701 has finished for PR 7701 at commit
|
|
Test build #38704 has finished for PR 7701 at commit
|
|
Test build #38709 has finished for PR 7701 at commit
|
Contributor
|
LGTM. Thanks @trestletech -- Merging this |
asfgit
pushed a commit
that referenced
this pull request
Jul 28, 2015
Otherwise, `sparkR.init()` with multiple `sparkPackages` results in this warning:
```
Warning message:
In if (packages != "") { :
the condition has length > 1 and only the first element will be used
```
Author: trestletech <jeff.allen@trestletechnology.net>
Closes #7701 from trestletech/compare-packages and squashes the following commits:
72c8b36 [trestletech] Correct function name.
c52db0e [trestletech] Added test for multiple packages.
3aab1a7 [trestletech] Use vector-friendly comparison for packages argument.
(cherry picked from commit 6143234)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise,
sparkR.init()with multiplesparkPackagesresults in this warning: