Skip to content

[SPARK-1819] [SQL] Fix GetField.nullable. #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-1819] [SQL] Fix GetField.nullable. #757

wants to merge 2 commits into from

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented May 13, 2014

GetField.nullable should be true not only when field.nullable is true but also when child.nullable is true.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14939/

marmbrus
marmbrus reviewed May 13, 2014
View reviewed changes
...yst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala Outdated
Copy link
Contributor

@marmbrus marmbrus May 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use named parameters (nullable = false) for boolean variables.

Copy link
Member Author

@ueshin ueshin May 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment.
I'll modify them to use named parameters.

@marmbrus
Copy link
Contributor

marmbrus commented May 13, 2014

Good catch! Only a minor comment.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 14, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14954/

@marmbrus
Copy link
Contributor

marmbrus commented May 15, 2014

@rxin or @pwendell please merge.

@rxin
Copy link
Contributor

rxin commented May 15, 2014

Thanks. Merged into master & branch-1.0.

asfgit pushed a commit that referenced this pull request May 15, 2014
@ueshin @rxin
[SPARK-1819] [SQL] Fix GetField.nullable.
f9eeddc 
`GetField.nullable` should be `true` not only when `field.nullable` is `true` but also when `child.nullable` is `true`.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes #757 from ueshin/issues/SPARK-1819 and squashes the following commits:

8781a11 [Takuya UESHIN] Modify a test to use named parameters.
5bfc77d [Takuya UESHIN] Fix GetField.nullable.

(cherry picked from commit 94c9d6f)
Signed-off-by: Reynold Xin <rxin@apache.org>
@asfgit asfgit closed this in 94c9d6f May 15, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@ueshin @pdeyhim
[SPARK-1819] [SQL] Fix GetField.nullable.
21e021b 
`GetField.nullable` should be `true` not only when `field.nullable` is `true` but also when `child.nullable` is `true`.

Author: Takuya UESHIN <ueshin@happy-camper.st>

Closes apache#757 from ueshin/issues/SPARK-1819 and squashes the following commits:

8781a11 [Takuya UESHIN] Modify a test to use named parameters.
5bfc77d [Takuya UESHIN] Fix GetField.nullable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ueshin @AmplabJenkins @marmbrus @rxin