Skip to content

SPARK-1793 - Heavily duplicated test setup code in SVMSuite #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ajtulloch
Copy link
Contributor

Summary:
https://issues.apache.org/jira/browse/SPARK-1793

Refactor the code to remove the repeated initialization of
test/validation RDDs in every test.

Test Plan:
Unit tests cover this code and pass with this update.

Reviewers:

CC:

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@ajtulloch
Copy link
Contributor Author

git diff --patience gives a cleaner view - https://gist.github.com/ajtulloch/3d9925c2f2252283ef61

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14880/

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14948/

Summary:
Refactor the code to remove the repeated initialization of
test/validation RDDs in every test.

Test Plan:
Unit tests cover this code and pass with this update.

Reviewers:

CC:
@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14956/

@ajtulloch
Copy link
Contributor Author

Is there any interest in this diff? Happy to close if otherwise.

@pwendell
Copy link
Contributor

pwendell commented Sep 2, 2014

hey @ajtulloch can you tag the title here with [MLlib]? As it stands this isn't getting sorted correctly so that's why @mengxr probably hasn't seen it to give feedback.

@mengxr
Copy link
Contributor

mengxr commented Sep 3, 2014

Jenkins, test this please.

@mengxr
Copy link
Contributor

mengxr commented Sep 3, 2014

@ajtulloch Sorry, I overlooked this PR. Thanks for simplifying the test code! Let's see whether it still merges cleanly or not.

@SparkQA
Copy link

SparkQA commented Sep 3, 2014

QA tests have started for PR 726 at commit a300b86.

  • This patch does not merge cleanly!

@SparkQA
Copy link

SparkQA commented Sep 3, 2014

QA tests have finished for PR 726 at commit a300b86.

  • This patch fails unit tests.
  • This patch does not merge cleanly!

@pwendell
Copy link
Contributor

@ajtulloch any interest in updating? If not, we should close this issue and can re-open later.

@asfgit asfgit closed this in a48956f Sep 19, 2014
agirish pushed a commit to HPEEzmeral/apache-spark that referenced this pull request May 5, 2022
…MapRFileSystem not found for spark-hive integration jobs (apache#726)
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
…MapRFileSystem not found for spark-hive integration jobs (apache#726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants