Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jul 2, 2015

It's a really minor issue but there is an example with wrong lambda-expression usage in SQLContext.scala like as follows.

sqlContext.udf().register("myUDF",
       (Integer arg1, String arg2) -> arg2 + arg1),  <- We have an extra `)` here.
       DataTypes.StringType);

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #36383 has finished for PR 7187 at commit a13196d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jul 2, 2015

retest this please.

@srowen
Copy link
Member

srowen commented Jul 2, 2015

LGTM. Unrelated failure but let's do it again

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #36386 has finished for PR 7187 at commit a13196d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 2, 2015

Test build #994 has finished for PR 7187 at commit a13196d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Heartbeat(workerId: String, worker: RpcEndpointRef) extends DeployMessage
    • case class RegisteredWorker(master: RpcEndpointRef, masterWebUiUrl: String) extends DeployMessage
    • case class RegisterApplication(appDescription: ApplicationDescription, driver: RpcEndpointRef)
    • case class RegisteredApplication(appId: String, master: RpcEndpointRef) extends DeployMessage
    • case class SubmitDriverResponse(
    • case class KillDriverResponse(
    • case class MasterChanged(master: RpcEndpointRef, masterWebUiUrl: String)
    • class DCT(override val uid: String)
    • class MinMaxScaler(override val uid: String)
    • class PCA (override val uid: String) extends Estimator[PCAModel] with PCAParams
    • class StreamingLinearAlgorithm(object):
    • class StreamingLinearRegressionWithSGD(StreamingLinearAlgorithm):
    • class AnalysisException(Exception):
    • class FlumeUtils(object):
    • case class Cast(child: Expression, dataType: DataType) extends UnaryExpression with Logging
    • trait ExpectsInputTypes
    • trait AutoCastInputTypes
    • abstract class BinaryExpression extends Expression with trees.BinaryNode[Expression]
    • abstract class BinaryOperator extends BinaryExpression
    • trait ExtractValue
    • abstract class ExtractValueWithStruct extends UnaryExpression with ExtractValue
    • abstract class ExtractValueWithOrdinal extends BinaryExpression with ExtractValue
    • abstract class BinaryArithmetic extends BinaryOperator
    • class SpecificOrdering extends $
    • class SpecificProjection extends $
    • final class SpecificRow extends $
    • case class UnHex(child: Expression) extends UnaryExpression with Serializable
    • case class Crc32(child: Expression)
    • abstract class BinaryComparison extends BinaryOperator with Predicate
    • // compiled class file for the closure here will conflict with the one in callUDF (upper case).

@sarutak
Copy link
Member Author

sarutak commented Jul 2, 2015

Merging into master and branch-1.4.

asfgit pushed a commit that referenced this pull request Jul 2, 2015
It's a really minor issue but there is an example with wrong lambda-expression usage in `SQLContext.scala` like as follows.

```
sqlContext.udf().register("myUDF",
       (Integer arg1, String arg2) -> arg2 + arg1),  <- We have an extra `)` here.
       DataTypes.StringType);
```

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #7187 from sarutak/fix-minor-wrong-lambda-expression and squashes the following commits:

a13196d [Kousuke Saruta] Fixed minor wrong lambda expression example.

(cherry picked from commit 4158836)
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
@asfgit asfgit closed this in 4158836 Jul 2, 2015
@sarutak sarutak deleted the fix-minor-wrong-lambda-expression branch April 12, 2016 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants