-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3629] [YARN] [DOCS]: Improvement of the "Running Spark on YARN" document #6924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
@srowen, could you please review when you get the chance? Thank you. |
|
@nssalian you don't need me specifically to review it, but I can. There was a previous pull request for this issue, and the feedback was that this diff doesn't expose what if anything you edited in the text? is it just a move, or also an edit? Ideally, if it's also an edit, you'd make two commits: one to edit and one to move. Then it's easy to browse the changes separately. Overall I think it's still OK to honor Matei's request here and move the text, yes. I am not sure if the help text still needs updating, but that's beyond just a doc update right? I don't see that here. Maybe I missed the intent. |
|
Yeah, moving the text seems fine. I'm going to make a few small comments on the text itself. |
docs/running-on-yarn.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'the dfs' -> 'HDFS'
|
@mateiz made the changes. Not sure about the master yarn sentence. Thank you. |
docs/running-on-yarn.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--master yarn-cluster should be the same as --master yarn and --deploy-mode cluster. I thought the latter was less-used, and none of the examples show it on this page. Therefore how about removing this reference to --deploy-mode here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Changed it.
|
I think this looks pretty good; let's leave it open a day or so. |
|
That is correct. I moved the texts a few commits ago. The latter commits were just formatting and changing yarn. |
|
@mateiz, does this PR need any more changes? Please let me know. |
|
I've eyeballed the change again and looks like it's consistent with everyone's intentions. I'll merge after checking that docs build after this doc-only change. |
…" document As per the description in the JIRA, I moved the contents of the page and added a few additional content. Author: Neelesh Srinivas Salian <nsalian@cloudera.com> Closes #6924 from nssalian/SPARK-3629 and squashes the following commits: 944b7a0 [Neelesh Srinivas Salian] Changed the lines about deploy-mode and added backticks to all parameters 40dbc0b [Neelesh Srinivas Salian] Changed dfs to HDFS, deploy-mode in backticks and updated the master yarn line 9cbc072 [Neelesh Srinivas Salian] Updated a few lines in the Launching Spark on YARN Section 8e8db7f [Neelesh Srinivas Salian] Removed the changes in this commit to help clearly distinguish movement from update 151c298 [Neelesh Srinivas Salian] SPARK-3629: Improvement of the Spark on YARN document (cherry picked from commit d48e789) Signed-off-by: Sean Owen <sowen@cloudera.com>
As per the description in the JIRA, I moved the contents of the page and added a few additional content.