Skip to content

[SPARK-8060] Improve DataFrame Python test coverage and documentation. #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Jun 3, 2015

No description provided.

@rxin
Copy link
Contributor Author

rxin commented Jun 3, 2015

cc @davies

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34044 has finished for PR 6601 at commit c9902fa.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin rxin changed the title [SPARK-8060] Improve DataFrame Python reader/writer interface doc and testing. [SPARK-8060] Improve DataFrame Python test coverage and documentation. Jun 3, 2015
@@ -196,7 +199,7 @@ def _inferSchema(self, rdd, samplingRatio=None):
"can not infer schema")
if type(first) is dict:
warnings.warn("Using RDD of dict to inferSchema is deprecated,"
"please use pyspark.sql.Row instead")
"please use pyspark.sql.Row instead", DeprecationWarning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeprecationWarning is ignored by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean we should remove all DeprecationWarning?

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34049 has finished for PR 6601 at commit f081d47.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Jun 3, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34064 has finished for PR 6601 at commit baa8ad5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jun 3, 2015
Author: Reynold Xin <rxin@databricks.com>

Closes #6601 from rxin/python-read-write-test-and-doc and squashes the following commits:

baa8ad5 [Reynold Xin] Code review feedback.
f081d47 [Reynold Xin] More documentation updates.
c9902fa [Reynold Xin] [SPARK-8060] Improve DataFrame Python reader/writer interface doc and testing.

(cherry picked from commit ce320cb)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in ce320cb Jun 3, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Author: Reynold Xin <rxin@databricks.com>

Closes apache#6601 from rxin/python-read-write-test-and-doc and squashes the following commits:

baa8ad5 [Reynold Xin] Code review feedback.
f081d47 [Reynold Xin] More documentation updates.
c9902fa [Reynold Xin] [SPARK-8060] Improve DataFrame Python reader/writer interface doc and testing.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Author: Reynold Xin <rxin@databricks.com>

Closes apache#6601 from rxin/python-read-write-test-and-doc and squashes the following commits:

baa8ad5 [Reynold Xin] Code review feedback.
f081d47 [Reynold Xin] More documentation updates.
c9902fa [Reynold Xin] [SPARK-8060] Improve DataFrame Python reader/writer interface doc and testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants