[SPARK-8021] [SQL] [PYSPARK] make Python read/write API consistent with Scala #6578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol I've been working on this too in the last 20 mins. |
| @@ -194,6 +219,48 @@ def __init__(self, df): | |||
| self._sqlContext = df.sql_ctx | |||
| self._jwrite = df._jdf.write() | |||
|
|
|||
| def mode(self, saveMode): | |||
added 2 commits
June 2, 2015 00:05
|
LGTM. We should add tests too (maybe later so we can make this in 1.4) |
|
Test build #33965 has finished for PR 6578 at commit
|
|
Test build #33969 has finished for PR 6578 at commit
|
|
Test build #33970 has finished for PR 6578 at commit
|
|
Jenkins, retest this please. |
|
This failed a totally unrelated streaming test, so I think it's okay. |
asfgit
pushed a commit
that referenced
this pull request
Jun 2, 2015
…th Scala add schema()/format()/options() for reader, add mode()/format()/options()/partitionBy() for writer cc rxin yhuai pwendell Author: Davies Liu <davies@databricks.com> Closes #6578 from davies/readwrite and squashes the following commits: 720d293 [Davies Liu] address comments b65dfa2 [Davies Liu] Update readwriter.py 1299ab6 [Davies Liu] make Python API consistent with Scala (cherry picked from commit 445647a) Signed-off-by: Patrick Wendell <patrick@databricks.com>
|
@pwendell but Python hasn't even run yet because it runs after the Scala streaming tests |
|
Test build #33993 has finished for PR 6578 at commit
|
|
Test build #870 has finished for PR 6578 at commit
|
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
…th Scala add schema()/format()/options() for reader, add mode()/format()/options()/partitionBy() for writer cc rxin yhuai pwendell Author: Davies Liu <davies@databricks.com> Closes apache#6578 from davies/readwrite and squashes the following commits: 720d293 [Davies Liu] address comments b65dfa2 [Davies Liu] Update readwriter.py 1299ab6 [Davies Liu] make Python API consistent with Scala
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
…th Scala add schema()/format()/options() for reader, add mode()/format()/options()/partitionBy() for writer cc rxin yhuai pwendell Author: Davies Liu <davies@databricks.com> Closes apache#6578 from davies/readwrite and squashes the following commits: 720d293 [Davies Liu] address comments b65dfa2 [Davies Liu] Update readwriter.py 1299ab6 [Davies Liu] make Python API consistent with Scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add schema()/format()/options() for reader, add mode()/format()/options()/partitionBy() for writer
cc @rxin @yhuai @pwendell