[SPARK-7547][ML] Scala Example code for ElasticNet #6576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #33962 has finished for PR 6576 at commit
|
|
Test build #33966 has finished for PR 6576 at commit
|
| s"L1 and L2, default: ${defaultParams.elasticNetParam}") | ||
| .action((x, c) => c.copy(elasticNetParam = x)) | ||
| opt[Int]("maxIter") | ||
| .text(s"maximal number of iterations, default: ${defaultParams.maxIter}") |
There was a problem hiding this comment.
I'd say "maximum" since "maximal" often implies there are multiple maxima.
|
Looks good other than those small comments. Thanks! |
|
Test build #34015 has finished for PR 6576 at commit
|
| .setElasticNetParam(params.elasticNetParam) | ||
| .setMaxIter(params.maxIter) | ||
| .setTol(params.tol) | ||
| .setMaxIter(params.maxIter) |
|
Test build #34027 has finished for PR 6576 at commit
|
|
Test build #34033 has finished for PR 6576 at commit
|
|
LGTM, merging with master and branch-1.4 |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2015
This is scala example code for both linear and logistic regression. Python and Java versions are to be added. Author: DB Tsai <dbt@netflix.com> Closes #6576 from dbtsai/elasticNetExample and squashes the following commits: e7ca406 [DB Tsai] fix test 6bb6d77 [DB Tsai] fix suite and remove duplicated setMaxIter 136e0dd [DB Tsai] address feedback 1ec29d4 [DB Tsai] fix style 9462f5f [DB Tsai] add example (cherry picked from commit a86b3e9) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
This is scala example code for both linear and logistic regression. Python and Java versions are to be added. Author: DB Tsai <dbt@netflix.com> Closes apache#6576 from dbtsai/elasticNetExample and squashes the following commits: e7ca406 [DB Tsai] fix test 6bb6d77 [DB Tsai] fix suite and remove duplicated setMaxIter 136e0dd [DB Tsai] address feedback 1ec29d4 [DB Tsai] fix style 9462f5f [DB Tsai] add example
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This is scala example code for both linear and logistic regression. Python and Java versions are to be added. Author: DB Tsai <dbt@netflix.com> Closes apache#6576 from dbtsai/elasticNetExample and squashes the following commits: e7ca406 [DB Tsai] fix test 6bb6d77 [DB Tsai] fix suite and remove duplicated setMaxIter 136e0dd [DB Tsai] address feedback 1ec29d4 [DB Tsai] fix style 9462f5f [DB Tsai] add example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is scala example code for both linear and logistic regression. Python and Java versions are to be added.