[SPARK-7927] Turn whitespace checker on for more token types. #6487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @mengxr |
Contributor
|
LGTM |
|
Test build #33709 has finished for PR 6487 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 29, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: #6480 #6478 #6477 #6476 #6475 #6474 #6473 Author: Reynold Xin <rxin@databricks.com> Closes #6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types. (cherry picked from commit 97a60cf) Signed-off-by: Reynold Xin <rxin@databricks.com>
rxin
changed the title
Contributor
|
Hi, this commit is just before the Is this intended or am I doing something wrong? |
Contributor
Author
|
I'm going to push a fix to it. |
Contributor
Author
|
Ok I pushed. It should work now. |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: apache#6480 apache#6478 apache#6477 apache#6476 apache#6475 apache#6474 apache#6473 Author: Reynold Xin <rxin@databricks.com> Closes apache#6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types.
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: apache#6480 apache#6478 apache#6477 apache#6476 apache#6475 apache#6474 apache#6473 Author: Reynold Xin <rxin@databricks.com> Closes apache#6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last batch of changes to complete SPARK-7929.
Previous related PRs:
#6480
#6478
#6477
#6476
#6475
#6474
#6473