Skip to content

Conversation

@Sephiroth-Lin
Copy link
Contributor

These R process only used to communicate with JVM process on local, so binding to localhost is more reasonable then wildcard ip.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32389 has finished for PR 6053 at commit 5303af7.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32403 has finished for PR 6053 at commit 5303af7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

@Sephiroth-Lin - Thanks for the change. Would you be able to test this on Windows just to make sure things work as expected ? I don't think there should be any problems, but I just want to be sure.

cc @davies

@Sephiroth-Lin
Copy link
Contributor Author

@shivaram Yes, I also think there should be no problems, as it is not system dependent. I will test this on Windows, thank you!

@davies
Copy link
Contributor

davies commented May 13, 2015

LGTM.

@shivaram
Copy link
Contributor

I just tested this on Windows and it works fine. LGTM. Merging this

asfgit pushed a commit that referenced this pull request May 13, 2015
…Socket server

These R process only used to communicate with JVM process on local, so binding to localhost is more reasonable then wildcard ip.

Author: linweizhong <linweizhong@huawei.com>

Closes #6053 from Sephiroth-Lin/spark-7526 and squashes the following commits:

5303af7 [linweizhong] bind to localhost rather than wildcard ip

(cherry picked from commit 98195c3)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
@asfgit asfgit closed this in 98195c3 May 13, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
…Socket server

These R process only used to communicate with JVM process on local, so binding to localhost is more reasonable then wildcard ip.

Author: linweizhong <linweizhong@huawei.com>

Closes apache#6053 from Sephiroth-Lin/spark-7526 and squashes the following commits:

5303af7 [linweizhong] bind to localhost rather than wildcard ip
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
…Socket server

These R process only used to communicate with JVM process on local, so binding to localhost is more reasonable then wildcard ip.

Author: linweizhong <linweizhong@huawei.com>

Closes apache#6053 from Sephiroth-Lin/spark-7526 and squashes the following commits:

5303af7 [linweizhong] bind to localhost rather than wildcard ip
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
…Socket server

These R process only used to communicate with JVM process on local, so binding to localhost is more reasonable then wildcard ip.

Author: linweizhong <linweizhong@huawei.com>

Closes apache#6053 from Sephiroth-Lin/spark-7526 and squashes the following commits:

5303af7 [linweizhong] bind to localhost rather than wildcard ip
@Sephiroth-Lin Sephiroth-Lin deleted the spark-7526 branch May 15, 2016 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants