[SPARK-7444][Tests] Eliminate noisy css warn/error logs for UISeleniumSuite #5983

zsxwing · 2015-05-07T17:34:35Z

Eliminate the following noisy logs for UISeleniumSuite:

15/05/07 10:09:50.196 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://192.168.0.170:4040/static/bootstrap.min.css' [793:167] Error in style rule. (Invalid token "*". Was expecting one of: <EOF>, <S>, <IDENT>, "}", ";".)
15/05/07 10:09:50.196 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS warning: 'http://192.168.0.170:4040/static/bootstrap.min.css' [793:167] Ignoring the following declarations in this rule.
15/05/07 10:09:50.197 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://192.168.0.170:4040/static/bootstrap.min.css' [799:325] Error in style rule. (Invalid token "*". Was expecting one of: <EOF>, <S>, <IDENT>, "}", ";".)
15/05/07 10:09:50.197 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS warning: 'http://192.168.0.170:4040/static/bootstrap.min.css' [799:325] Ignoring the following declarations in this rule.
15/05/07 10:09:50.198 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://192.168.0.170:4040/static/bootstrap.min.css' [805:18] Error in style rule. (Invalid token "*". Was expecting one of: <EOF>, <S>, <IDENT>, "}", ";".)
15/05/07 10:09:50.198 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS warning: 'http://192.168.0.170:4040/static/bootstrap.min.css' [805:18] Ignoring the following declarations in this rule.

zsxwing · 2015-05-07T17:35:10Z

cc @tianyi @marmbrus @JoshRosen

zsxwing · 2015-05-07T17:37:01Z

core/src/main/resources/org/apache/spark/ui/static/streaming-page.css

@@ -31,7 +31,7 @@
 }

 .tooltip-inner {
-  max-width: 500px !important; // Make sure we only have one line tooltip


I just found this incorrect comment as per the error log. So I think we should not totally turn off all logs. That's why this PR only ignores logs from "bootstrap.min.css" and "vis.min.css".

AmplabJenkins · 2015-05-07T17:37:11Z

Merged build triggered.

AmplabJenkins · 2015-05-07T17:37:16Z

Merged build started.

SparkQA · 2015-05-07T17:39:16Z

Test build #32125 has started for PR 5983 at commit a59f40e.

tdas · 2015-05-07T19:12:01Z

Can you elaborate a little on what the DefaultCssErrorHandler solves.

tdas · 2015-05-07T19:12:33Z

core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala

-    webDriver = new HtmlUnitDriver
+    webDriver = new HtmlUnitDriver {
+
+      getWebClient.setCssErrorHandler(new DefaultCssErrorHandler {


This new handler's code is triplicated. Cant you just define a class?

Is there a place for common test classes for all projects?

We can put the test class into core then have the other projects declare a test-jar test dependency on core. I think that SQL uses this pattern to share test code between SQL core and catalyst.

Does Core build a test-jar now?

zsxwing · 2015-05-07T19:19:13Z

@tdas DefaultCssErrorHandler outputs all css warn/error logs. This PR just changes its behavior to: if the warn/error is from "bootstrap.min.css" and "vis.min.css", which should be a false alarm, just ignore it.

SparkQA · 2015-05-07T20:02:42Z

Test build #32125 has finished for PR 5983 at commit a59f40e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-07T20:02:47Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-07T20:02:48Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32125/
Test PASSed.

tianyi · 2015-05-08T08:12:28Z

@zsxwing Maybe we could define a log level instead of whitelist?
because:
1 We should not ignore all kinds of logs including error and fatal error.
2 It will be hard for us to maintain a whitelist of all CSS filenames.

zsxwing · 2015-05-08T17:40:16Z

@tianyi here I just ignored the trusted libraries's filename, "bootstrap.min.css" and "vis.min.css". I'm also against ignoring all CSS filenames.

Maybe we could define a log level instead of whitelist?

Which level are you suggesting? They are "WARN". I cannot find a better level for it.

AmplabJenkins · 2015-05-08T17:52:12Z

Merged build triggered.

AmplabJenkins · 2015-05-08T17:52:17Z

Merged build started.

SparkQA · 2015-05-08T17:53:52Z

Test build #32248 has started for PR 5983 at commit 7bb7f11.

SparkQA · 2015-05-08T20:20:13Z

Test build #32248 has finished for PR 5983 at commit 7bb7f11.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- public class EnumUtil

AmplabJenkins · 2015-05-08T20:20:18Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-08T20:20:18Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32248/
Test PASSed.

AmplabJenkins · 2015-06-08T16:17:15Z

Merged build triggered.

AmplabJenkins · 2015-06-08T16:17:24Z

Merged build started.

SparkQA · 2015-06-08T16:20:00Z

Test build #34452 has started for PR 5983 at commit 4202728.

SparkQA · 2015-06-08T18:36:28Z

Test build #34452 has finished for PR 5983 at commit 4202728.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-06-08T18:36:33Z

Merged build finished. Test PASSed.

marmbrus · 2015-06-11T21:21:18Z

Thanks, merging to master!

…umSuite Eliminate the following noisy logs for `UISeleniumSuite`: ``` 15/05/07 10:09:50.196 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://192.168.0.170:4040/static/bootstrap.min.css' [793:167] Error in style rule. (Invalid token "*". Was expecting one of: <EOF>, <S>, <IDENT>, "}", ";".) 15/05/07 10:09:50.196 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS warning: 'http://192.168.0.170:4040/static/bootstrap.min.css' [793:167] Ignoring the following declarations in this rule. 15/05/07 10:09:50.197 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://192.168.0.170:4040/static/bootstrap.min.css' [799:325] Error in style rule. (Invalid token "*". Was expecting one of: <EOF>, <S>, <IDENT>, "}", ";".) 15/05/07 10:09:50.197 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS warning: 'http://192.168.0.170:4040/static/bootstrap.min.css' [799:325] Ignoring the following declarations in this rule. 15/05/07 10:09:50.198 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://192.168.0.170:4040/static/bootstrap.min.css' [805:18] Error in style rule. (Invalid token "*". Was expecting one of: <EOF>, <S>, <IDENT>, "}", ";".) 15/05/07 10:09:50.198 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS warning: 'http://192.168.0.170:4040/static/bootstrap.min.css' [805:18] Ignoring the following declarations in this rule. ``` Author: zsxwing <zsxwing@gmail.com> Closes apache#5983 from zsxwing/SPARK-7444 and squashes the following commits: 4202728 [zsxwing] Add SparkUICssErrorHandler for all tests d1398ad [zsxwing] Merge remote-tracking branch 'origin/master' into SPARK-7444 7bb7f11 [zsxwing] Merge branch 'master' into SPARK-7444 a59f40e [zsxwing] Eliminate noisy css warn/error logs for UISeleniumSuite

Eliminate noisy css warn/error logs for UISeleniumSuite

a59f40e

zsxwing reviewed May 7, 2015
View reviewed changes

tdas reviewed May 7, 2015
View reviewed changes

tianyi mentioned this pull request May 8, 2015

[SPARK-5100][SQL]add webui for thriftserver #5730

Closed

Merge branch 'master' into SPARK-7444

7bb7f11

zsxwing added 2 commits June 9, 2015 00:11

Merge remote-tracking branch 'origin/master' into SPARK-7444

d1398ad

Add SparkUICssErrorHandler for all tests

4202728

asfgit closed this in 95690a1 Jun 11, 2015

zsxwing deleted the SPARK-7444 branch June 11, 2015 23:58

andrewor14 mentioned this pull request Jul 4, 2015

[SPARK-8819] Fix build for maven 3.3.x #7219

Closed

xkrogen mentioned this pull request Jun 22, 2020

[SPARK-32036] Replace references to blacklist/whitelist language with more appropriate terminology, excluding the blacklisting feature. #28874

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-7444][Tests] Eliminate noisy css warn/error logs for UISeleniumSuite #5983

[SPARK-7444][Tests] Eliminate noisy css warn/error logs for UISeleniumSuite #5983

zsxwing commented May 7, 2015

zsxwing commented May 7, 2015

zsxwing May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

SparkQA commented May 7, 2015

tdas commented May 7, 2015

tdas May 7, 2015

zsxwing May 7, 2015

JoshRosen May 22, 2015

zsxwing May 22, 2015

zsxwing commented May 7, 2015

SparkQA commented May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

tianyi commented May 8, 2015

zsxwing commented May 8, 2015

AmplabJenkins commented May 8, 2015

AmplabJenkins commented May 8, 2015

SparkQA commented May 8, 2015

SparkQA commented May 8, 2015

AmplabJenkins commented May 8, 2015

AmplabJenkins commented May 8, 2015

AmplabJenkins commented Jun 8, 2015

AmplabJenkins commented Jun 8, 2015

SparkQA commented Jun 8, 2015

SparkQA commented Jun 8, 2015

AmplabJenkins commented Jun 8, 2015

marmbrus commented Jun 11, 2015

[SPARK-7444][Tests] Eliminate noisy css warn/error logs for UISeleniumSuite #5983

[SPARK-7444][Tests] Eliminate noisy css warn/error logs for UISeleniumSuite #5983

Conversation

zsxwing commented May 7, 2015

zsxwing commented May 7, 2015

zsxwing May 7, 2015

Choose a reason for hiding this comment

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

SparkQA commented May 7, 2015

tdas commented May 7, 2015

tdas May 7, 2015

Choose a reason for hiding this comment

zsxwing May 7, 2015

Choose a reason for hiding this comment

JoshRosen May 22, 2015

Choose a reason for hiding this comment

zsxwing May 22, 2015

Choose a reason for hiding this comment

zsxwing commented May 7, 2015

SparkQA commented May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

tianyi commented May 8, 2015

zsxwing commented May 8, 2015

AmplabJenkins commented May 8, 2015

AmplabJenkins commented May 8, 2015

SparkQA commented May 8, 2015

SparkQA commented May 8, 2015

AmplabJenkins commented May 8, 2015

AmplabJenkins commented May 8, 2015

AmplabJenkins commented Jun 8, 2015

AmplabJenkins commented Jun 8, 2015

SparkQA commented Jun 8, 2015

SparkQA commented Jun 8, 2015

AmplabJenkins commented Jun 8, 2015

marmbrus commented Jun 11, 2015