[SPARK-7092] Update spark scala version to 2.11.6 #5662
Conversation
|
@pwendell Please take a look :) |
|
Test build #30838 has started for PR 5662 at commit |
| @@ -1129,7 +1129,7 @@ class SparkIMain(@BeanProperty val factory: ScriptEngineFactory, initialSettings | |||
|
|
|||
| def apply(line: String): Result = debugging(s"""parse("$line")""") { | |||
| var isIncomplete = false | |||
| currentRun.reporting.withIncompleteHandler((_, _) => isIncomplete = true) { | |||
| currentRun.parsing.withIncompleteHandler((_, _) => isIncomplete = true) { | |||
There was a problem hiding this comment.
Just curious, was this a break across maintenance releases? or is this basically not a public Scala API anyway?
Are there any potential gotchas in updating? You know more than I would. I tend to favor updating as well to get fixes.
There was a problem hiding this comment.
This was the change, it corresponds to scala/scala@64ebac2
There was a problem hiding this comment.
It is harmless, if not beneficial. But this can be a stepping stone towards enabling add jars, because then we have two options 1) back port scala's version of add jars 2) port spark scala 2.10 repl's version of add jars on the fly.
Without this patch such a option does not exist. I agree best thing is to patch scala/scala so that we do not have to maintain repl(s). So I am working on it, with whatever time I have.
|
Test build #30838 has finished for PR 5662 at commit
|
|
Test PASSed. |
Author: Prashant Sharma <prashant.s@imaginea.com> Closes apache#5662 from ScrapCodes/SPARK-7092/scala-update-2.11.6 and squashes the following commits: 58cf4f9 [Prashant Sharma] [SPARK-7092] Update spark scala version to 2.11.6
Author: Prashant Sharma <prashant.s@imaginea.com> Closes apache#5662 from ScrapCodes/SPARK-7092/scala-update-2.11.6 and squashes the following commits: 58cf4f9 [Prashant Sharma] [SPARK-7092] Update spark scala version to 2.11.6
No description provided.