Skip to content

[SPARK-6991] [SparkR] Adds support for zipPartitions. #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-6991] [SparkR] Adds support for zipPartitions. #5568

wants to merge 4 commits into from

Conversation

hlin09
Copy link
Contributor

@hlin09 hlin09 commented Apr 18, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Apr 18, 2015

Test build #30512 has finished for PR 5568 at commit ec56d2f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@concretevitamin
Copy link
Contributor

Thanks @hlin09 - one high-level question: do you have an intended use case in mind for arbitrary / large arity functions? In Spark's Scala API up to 4 RDDs are supported, which has perf. benefits (avoid an union + shuffle).

@hlin09
Copy link
Contributor Author

hlin09 commented Apr 21, 2015

I do have some user cases that would best to have more that 4 arity zip function. Another concern is that the current communication pattern between Spark and R does not allows tuples of more than RDDs. From perf point of view, "union + shuffle" might be better than recursively zip 2 of them.

concretevitamin
concretevitamin reviewed Apr 27, 2015
View reviewed changes
R/pkg/R/RDD.R
#' Zip an RDD's partitions with one (or more) RDD(s).
#'
#' Return a new RDD by applying a function to the zipped partitions.
#' Assumes that all the RDDs have the same number of partitions*, but does *not*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unmatched *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

@concretevitamin
Copy link
Contributor

@hlin09 - cool, I don't have a strong opinion towards either approach for now. Did a pass and left some minor style comments.

@SparkQA
Copy link

SparkQA commented Apr 27, 2015

Test build #31005 has started for PR 5568 at commit 12c08a5.

@concretevitamin
Copy link
Contributor

LGTM. /cc @shivaram

@shivaram
Copy link
Contributor

Thanks @concretevitamin for the review. Will merge this after Jenkins passes

@shivaram
Copy link
Contributor

Hmm this is weird - somehow the test results for this PR were never posted to github. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31005/consoleFull reports a json parsing error

cc @shaneknapp

@shivaram
Copy link
Contributor

I also re-ran the R tests locally to just verify -- Merging this.

@asfgit asfgit closed this in ca9f4eb Apr 27, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
@hlin09
[SPARK-6991] [SPARKR] Adds support for zipPartitions.
c9ed85c 
Author: hlin09 <hlin09pu@gmail.com>

Closes apache#5568 from hlin09/zipPartitions and squashes the following commits:

12c08a5 [hlin09] Fix comments
d2d32db [hlin09] Merge branch 'master' into zipPartitions
ec56d2f [hlin09] Fix test.
27655d3 [hlin09] Adds support for zipPartitions.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@hlin09 @nemccarthy
[SPARK-6991] [SPARKR] Adds support for zipPartitions.
afb9211 
Author: hlin09 <hlin09pu@gmail.com>

Closes apache#5568 from hlin09/zipPartitions and squashes the following commits:

12c08a5 [hlin09] Fix comments
d2d32db [hlin09] Merge branch 'master' into zipPartitions
ec56d2f [hlin09] Fix test.
27655d3 [hlin09] Adds support for zipPartitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlin09 @SparkQA @concretevitamin @shivaram