Skip to content

[SPARK-55717][BUILD] Use Google Mirror of Maven Central in MavenUtils#54519

Open
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-55717
Open

[SPARK-55717][BUILD] Use Google Mirror of Maven Central in MavenUtils#54519
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-55717

Conversation

@yaooqinn
Copy link
Member

What changes were proposed in this pull request?

Change the default Maven Central URL in MavenUtils.scala from repo1.maven.org to Google's Maven Central mirror (maven-central.storage-download.googleapis.com).

Why are the changes needed?

Follow-up of SPARK-55710 / #54508 (suggested by @sarutak). The SBT build already uses the Google mirror as the primary resolver. MavenUtils was still defaulting to repo1.maven.org for runtime dependency resolution (e.g., --packages). This makes it consistent.

The DEFAULT_ARTIFACT_REPOSITORY environment variable can still be used to override this.

Does this PR introduce any user-facing change?

Yes. The default repository URL for --packages resolution changes from Maven Central to its Google mirror. Users can override via DEFAULT_ARTIFACT_REPOSITORY.

How was this patch tested?

Existing tests. The change is a URL swap for the same Maven Central content.

Was this patch authored or co-authored using generative AI tooling?

Yes, GitHub Copilot CLI was used.

Change the default Maven Central URL in MavenUtils from repo1.maven.org to Google's Maven Central mirror for consistency with the SBT build (SPARK-55710). The DEFAULT_ARTIFACT_REPOSITORY environment variable can still override this.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dongjoon-hyun

This comment was marked as outdated.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, @yaooqinn . Does this PR aim for Spark jobs to use Google Mirror even in the private data centers when --package is given?

Yes. The default repository URL for --packages resolution changes from Maven Central to its Google mirror. Users can override via DEFAULT_ARTIFACT_REPOSITORY.

#54508 affects only for the developers to build Spark, but this PR sounds dangerous to me. I'm negative for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants