[SPARK-55647][SQL] Improve ConstantPropagation for collated AttributeReferences#54515
Open
ilicmarkodb wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-55647][SQL] Improve ConstantPropagation for collated AttributeReferences#54515ilicmarkodb wants to merge 1 commit intoapache:masterfrom
ConstantPropagation for collated AttributeReferences#54515ilicmarkodb wants to merge 1 commit intoapache:masterfrom
Conversation
ilicmarkodb
force-pushed
the
improve_ConstantPropagation
branch
from
ef34a58 to
474f351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The previous change (#54435) completely blocked
ConstantPropagationfor non-binary-stable types, leading to potential performance implications. In this PR, I propose improving the rule to replace collatedAttributeReferenceswhen it is safe.Why are the changes needed?
Perf improvement.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests.
Was this patch authored or co-authored using generative AI tooling?
No.