[SPARK-55463][PYTHON][FOLLOW-UP] Delete unnecessary date_as_object=True in VariantType conversion#54509
Open
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-55463][PYTHON][FOLLOW-UP] Delete unnecessary date_as_object=True in VariantType conversion#54509zhengruifeng wants to merge 1 commit intoapache:masterfrom
date_as_object=True in VariantType conversion#54509zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Delete unnecessary
date_as_object=TrueWhy are the changes needed?
1, VariantType is not supposed to include any date fields;
2,
date_as_objectactually defaults to True, according to the API referenceRemove it to be consistent with changes from https://github.com/apache/spark/pull/54303/changes
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?