[SPARK-54571][CORE] Use LZ4 safeDecompressor#54496
Closed
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-54571][CORE] Use LZ4 safeDecompressor#54496Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Do you have benchmark? Thanks. |
Member
|
You guys might have missed #53454 |
Contributor
Author
Oops, yeah sorry we have missed your PR. This was brought into sight again due to performance regression. I will close this one and let's move our discussion in your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switch
LZ4CompressionCodec.compressedInputStreamto uselz4Factory.safeDecompressor()instead oflz4Factory.fastDecompressor().Since Spark upgraded to
at.yawk.lz4:lz4-java:1.10.0(via #53327),LZ4BlockInputStreamnow has a Builder API that acceptsLZ4SafeDecompressor. This PR uses that API:This is a follow-up to #53290, which was blocked because
LZ4BlockInputStreamin lz4-java 1.8.0 did not acceptLZ4SafeDecompressor. The lz4-java 1.10.0 Builder API unblocks this change.Why are the changes needed?
As noted by the lz4-java maintainer (@yawkat) in #53290, as of lz4-java 1.8.1,
safeDecompressoris substantially faster thanfastDecompressor. The recommended migration path with proper performance is to usesafeDecompressorvia the 1.10.0+ Builder API.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.