Skip to content

[SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact #5429

wants to merge 1 commit into from

Conversation

chernetsov
Copy link
Contributor

turned on hive-thriftserver profile in release script

@pwendell
Copy link
Contributor

pwendell commented Apr 9, 2015

LGTM - thanks for sending this. Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Apr 9, 2015

Test build #29911 has finished for PR 5429 at commit c00aa17.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@pwendell
Copy link
Contributor

pwendell commented Apr 9, 2015

Actually sorry - I realized a problem with this. We can't merge this right now.

pwendell
pwendell reviewed Apr 9, 2015
View reviewed changes
dev/create-release/create-release.sh
clean install

./dev/change-version-to-2.11.sh

build/mvn -DskipTests -Dhadoop.version=2.2.0 -Dyarn.version=2.2.0 \
-Dscala-2.11 -Pyarn -Phive -Phadoop-2.2 -Pspark-ganglia-lgpl -Pkinesis-asl \
-Dscala-2.11 -Pyarn -Phive -Phive-thriftserver -Phadoop-2.2 -Pspark-ganglia-lgpl -Pkinesis-asl \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala 2.11 does not support the thriftserver because there is a JLine conflict between Scala 2.11's repl and the Hive CLI that makes it not compile correctly. So we can only do it for 2.10 right now.

@chernetsov chernetsov closed this Apr 9, 2015
@chernetsov
[SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact
9cc36af 
turned on hive-thriftserver profile in release script for scala 2.10
@chernetsov
Copy link
Contributor Author

@pwendell Reopenning with an just 2.10

@chernetsov chernetsov reopened this Apr 9, 2015
@pwendell
Copy link
Contributor

pwendell commented Apr 9, 2015

Jenkins, retest this please. LGTM

@SparkQA
Copy link

SparkQA commented Apr 9, 2015

Test build #29957 has finished for PR 5429 at commit 9cc36af.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@srowen
Copy link
Member

srowen commented Apr 15, 2015

Jenkins, retest this please

@srowen
Copy link
Member

srowen commented Apr 15, 2015

@pwendell are you still OK with this, for 1.4? seems not-crazy, except of course that now the project commits to publishing another artifact. I am not sure about the trade-offs there as I'm not so familiar with this module.

@SparkQA
Copy link

SparkQA commented Apr 15, 2015

Test build #30338 has finished for PR 5429 at commit 9cc36af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

@srowen thanks for pinging this. I will merge it. I ended up doing something manual for Spark 1.3.1 to allow us to publish this:

http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22spark-hive-thriftserver_2.10%22

@asfgit asfgit closed this in 998aac2 Apr 27, 2015
asfgit pushed a commit that referenced this pull request Apr 27, 2015
@chernetsov @pwendell
[SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact
81de30a 
turned on hive-thriftserver profile in release script

Author: Misha Chernetsov <chernetsov@gmail.com>

Closes #5429 from chernetsov/master and squashes the following commits:

9cc36af [Misha Chernetsov] [SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact turned on hive-thriftserver profile in release script for scala 2.10

(cherry picked from commit 998aac2)
Signed-off-by: Patrick Wendell <patrick@databricks.com>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
@chernetsov
[SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact
3eeace3 
turned on hive-thriftserver profile in release script

Author: Misha Chernetsov <chernetsov@gmail.com>

Closes apache#5429 from chernetsov/master and squashes the following commits:

9cc36af [Misha Chernetsov] [SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact turned on hive-thriftserver profile in release script for scala 2.10
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@chernetsov @nemccarthy
[SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact
7651cf1 
turned on hive-thriftserver profile in release script

Author: Misha Chernetsov <chernetsov@gmail.com>

Closes apache#5429 from chernetsov/master and squashes the following commits:

9cc36af [Misha Chernetsov] [SPARK-4925] Publish Spark SQL hive-thriftserver maven artifact turned on hive-thriftserver profile in release script for scala 2.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chernetsov @pwendell @SparkQA @srowen @AmplabJenkins