-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-6343] Doc driver-worker network reqs #5382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
The original diagram source is in the https://github.com/apache/spark/blob/master/docs/img/cluster-overview.pptx Would you like me to remove it as part of the PR? |
Oh I looked past that since it looked like a new file in Github. Yes leave it. |
LGTM; this is a nice improvement over the old diagram. |
Great to have an improvement here. One thing I don't understand, there are two curved arrows from the SparkContext to the Executors/Workers. However, in the upper arrow it is connected to the boundary of the Worker box and not the boundary of the Executor box. Is this intentional? I believe in theory, the process running the SparkContext should not need to directly communicate with the Worker nodes. It should only directly communicate with the Executor process. So maybe they should both touch the boundary of the Executor box. |
I have same question as Patrick too. |
Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers.
@pwendell @WangTaoTheTonic Good catch. I misconnected the upper line. It was not intentional. I've updated the PR with the diagram fix. |
Great LGTM - @WangTaoTheTonic does that look okay to you? |
LGTM +1 |
Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see https://issues.apache.org/jira/browse/SPARK-6343). Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers. Author: Peter Parente <pparent@us.ibm.com> Closes #5382 from parente/SPARK-6343 and squashes the following commits: 0b2fb9d [Peter Parente] [SPARK-6343] Doc driver-worker network reqs (cherry picked from commit b9c51c0) Signed-off-by: Sean Owen <sowen@cloudera.com>
Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see https://issues.apache.org/jira/browse/SPARK-6343).
Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers.