Skip to content

[SPARK-6343] Doc driver-worker network reqs #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

parente
Copy link
Contributor

@parente parente commented Apr 7, 2015

Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see https://issues.apache.org/jira/browse/SPARK-6343).

Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Apr 7, 2015

LGTM. What do you think @mateiz @pwendell @rxin ?
Also you don't need to include a PPTX file.

@parente
Copy link
Contributor Author

parente commented Apr 7, 2015

The original diagram source is in the docs/img/ folder already.

https://github.com/apache/spark/blob/master/docs/img/cluster-overview.pptx

Would you like me to remove it as part of the PR?

@srowen
Copy link
Member

srowen commented Apr 7, 2015

Oh I looked past that since it looked like a new file in Github. Yes leave it.

@JoshRosen
Copy link
Contributor

LGTM; this is a nice improvement over the old diagram.

@pwendell
Copy link
Contributor

pwendell commented Apr 9, 2015

Great to have an improvement here. One thing I don't understand, there are two curved arrows from the SparkContext to the Executors/Workers. However, in the upper arrow it is connected to the boundary of the Worker box and not the boundary of the Executor box. Is this intentional?

I believe in theory, the process running the SparkContext should not need to directly communicate with the Worker nodes. It should only directly communicate with the Executor process. So maybe they should both touch the boundary of the Executor box.

@WangTaoTheTonic
Copy link
Contributor

I have same question as Patrick too.

Update cluster overview diagram to show connections from workers
to driver. Add a bullet below about how driver listens / accepts
connections from workers.
@parente
Copy link
Contributor Author

parente commented Apr 9, 2015

@pwendell @WangTaoTheTonic Good catch. I misconnected the upper line. It was not intentional.

I've updated the PR with the diagram fix.

@pwendell
Copy link
Contributor

pwendell commented Apr 9, 2015

Great LGTM - @WangTaoTheTonic does that look okay to you?

@WangTaoTheTonic
Copy link
Contributor

LGTM +1

asfgit pushed a commit that referenced this pull request Apr 9, 2015
Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see https://issues.apache.org/jira/browse/SPARK-6343).

Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers.

Author: Peter Parente <pparent@us.ibm.com>

Closes #5382 from parente/SPARK-6343 and squashes the following commits:

0b2fb9d [Peter Parente] [SPARK-6343] Doc driver-worker network reqs

(cherry picked from commit b9c51c0)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in b9c51c0 Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants