Skip to content

[SPARK-6700] disable flaky test #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-6700] disable flaky test #5356

wants to merge 1 commit into from

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 3, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29696 has started for PR 5356 at commit 08955f4.

@davies
Copy link
Contributor Author

davies commented Apr 3, 2015

cc @andrewor14

sryza
sryza reviewed Apr 3, 2015
View reviewed changes
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
@@ -143,7 +143,8 @@ class YarnClusterSuite extends FunSuite with BeforeAndAfterAll with Matchers wit
}
}

test("run Python application in yarn-cluster mode") {
// Enable this once fix SPARK-6700
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is SPARK-6700 for disabling the flaky test or for the fix? It shouldn't be for both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue just describes the fact that YarnClusterSuite is flaky. This is probably fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but does it make sense to have statement that saying "change this once SPARK-6700 is resolved" as part of SPARK-6700?

@andrewor14
Copy link
Contributor

Merging this in master 1.3 since it's breaking builds.

@asfgit asfgit closed this in 9b40c17 Apr 3, 2015
asfgit pushed a commit that referenced this pull request Apr 3, 2015
[SPARK-6700] disable flaky test
3366af6 
Author: Davies Liu <davies@databricks.com>

Closes #5356 from davies/flaky and squashes the following commits:

08955f4 [Davies Liu] disable flaky test

(cherry picked from commit 9b40c17)
Signed-off-by: Andrew Or <andrew@databricks.com>
@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29696 has finished for PR 5356 at commit 08955f4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29696/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davies @SparkQA @andrewor14 @AmplabJenkins @sryza