[SPARK-54570][PYTHON] Propagate the error class correctly in Spark Connect #53288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shujingyang-db
changed the title
ueshin
approved these changes
Dec 2, 2025
Member
ueshin
left a comment
ueshin
left a comment
There was a problem hiding this comment.
LGTM.
cc @HyukjinKwon @zhengruifeng
HyukjinKwon
approved these changes
Dec 2, 2025
zhengruifeng
approved these changes
Dec 3, 2025
zhengruifeng
reviewed
Dec 3, 2025
|
|
||
| if __name__ == "__main__": | ||
| import unittest | ||
| from pyspark.errors.tests.test_errors import * # noqa: F401 |
Contributor
There was a problem hiding this comment.
@shujingyang-db I guess this test file is never tests before.
Suggested change
| from pyspark.errors.tests.test_connect_errors_conversion import * # noqa: F401 |
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Thanks for the fix
…ingyang-db/spark into fix-spark-connect-config-error
shujingyang-db
commented
Dec 3, 2025
| if __name__ == "__main__": | ||
| import unittest | ||
| from pyspark.errors.tests.test_errors import * # noqa: F401 | ||
| from pyspark.errors.tests.test_connect_errors_conversion import * # noqa: F401 |
ueshin
reviewed
Dec 4, 2025
|
|
||
| if __name__ == "__main__": | ||
| import unittest | ||
| from pyspark.errors.tests.test_errors import * # noqa: F401 |
Contributor
Author
There was a problem hiding this comment.
Let me revert it in a follow-up PR to unblock this
zhengruifeng
reviewed
Dec 4, 2025
|
|
||
| if __name__ == "__main__": | ||
| import unittest | ||
| from pyspark.errors.tests.test_errors import * # noqa: F401 |
Contributor
There was a problem hiding this comment.
Suggested change
| from pyspark.errors.tests.test_errors import * # noqa: F401 |
Contributor
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
spark.sql.connect.enrichError.enabledis enabled (default),message_parametersis retrieved fromroot_error.spark_throwableand set correctly. However,error_classwas not being retrieved/set in the same way, causing the error class information to be lost on the PySpark Connect client side. This PR fixes it by propagating the error class correctly.Why are the changes needed?
Fix a bug.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
Yes