Skip to content

Conversation

@gaogaotiantian
Copy link
Contributor

@gaogaotiantian gaogaotiantian commented Nov 22, 2025

What changes were proposed in this pull request?

We should fix the test_report workflow - it barely works.

  • Used the official download-artifacts to replace the 3rd party one
  • Unpinned the specific version of test report action
  • Used explicit permissions for the action

Why are the changes needed?

The problem is the 3rd party action used can't deal with non-zip files. In the orignal PR it was mentioned that the official download-artifact action should be used when it can download from other workflows. We should try to use that.

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the INFRA label Nov 22, 2025
@gaogaotiantian
Copy link
Contributor Author

I cancelled the PR but the result would be like https://github.com/gaogaotiantian/spark/actions/runs/19604352824/job/56143216972

It only works when it's in master so that's why I had to try this out in my repo.

@gaogaotiantian gaogaotiantian marked this pull request as ready for review November 23, 2025 04:38
@HyukjinKwon
Copy link
Member

Merged to master.

huangxiaopingRD pushed a commit to huangxiaopingRD/spark that referenced this pull request Nov 25, 2025
…eport action

### What changes were proposed in this pull request?

We should fix the `test_report` workflow - it barely works.

* Used the official download-artifacts to replace the 3rd party one
* Unpinned the specific version of test report action
* Used explicit permissions for the action

### Why are the changes needed?

The problem is the 3rd party action used can't deal with non-zip files. In the orignal [PR](apache#29333) it was mentioned that the official `download-artifact` action should be used when it can download from other workflows. We should try to use that.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

CI

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#53167 from gaogaotiantian/fix-report-action.

Authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@gaogaotiantian gaogaotiantian deleted the fix-report-action branch November 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants