[SPARK-53956][PYTHON] Support TIME in the try_make_timestamp function in PySpark #52666
+474
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
changed the title
uros-db
commented
Oct 20, 2025
There was a problem hiding this comment.
@zhengruifeng @HyukjinKwon Please review.
Also, here is the sibling PR for make_timestamp in PySpark: #52648.
|
cc @Yicong-Huang can you help review? thanks |
Sure |
Yicong-Huang
approved these changes
Oct 20, 2025
| +----------------------------------------------------+ | ||
| |2014-12-28 06:30:45.887 | | ||
| +----------------------------------------------------+ | ||
| >>> spark.conf.unset("spark.sql.session.timeZone") |
There was a problem hiding this comment.
seems that it was a mistake to introduce this line from the beginning (as time zone is not being used in the example), but want to double confirm this deletion is intentional.
| |try_make_timestamp(date, time, tz)| | ||
| +----------------------------------+ | ||
| |2014-12-27 21:30:45.887 | | ||
| +----------------------------------+ |
There was a problem hiding this comment.
do we need to add back >>> spark.conf.unset("spark.sql.session.timeZone")?
| mins: Optional["ColumnOrName"] = None, | ||
| secs: Optional["ColumnOrName"] = None, | ||
| timezone: Optional["ColumnOrName"] = None, | ||
| *, |
There was a problem hiding this comment.
we had a follow up PR #52461 to remove the * to make date and time also positional. shall we make it consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement the support for TIME type in
try_make_timestampfunction in PySpark API.Why are the changes needed?
Expand API support for the
TryMakeTimestampexpression.Does this PR introduce any user-facing change?
Yes, the new function is now available in PySpark API.
How was this patch tested?
Added appropriate Python functions tests and examples.
Was this patch authored or co-authored using generative AI tooling?
No.