[SPARK-53947][SQL] Count null in approx_top_k #52655
Open
+210
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add a nullCounter associated with the Frequent Item Sketch in
approx_top_kaggregation, so that now the function will return null item and null count if NULL value is among the top_k frequent items.Why are the changes needed?
NULL value could be meaningful in some use cases and users might want to include NULL in the approx_top_k output.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests on handling null values.
Was this patch authored or co-authored using generative AI tooling?
No.