[SPARK-53574][SQL][FOLLOWUP] still reset the default AnalysisContext #52482
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
approved these changes
Sep 30, 2025
| * expressions in a subquery. | ||
| */ | ||
| case class AnalysisContext( | ||
| isDefault: Boolean = false, |
There was a problem hiding this comment.
nit: do we consider putting this at the end of the parameter list?
There was a problem hiding this comment.
This should always be set when copying an AnalysisContext, so put it at the beginning as a highlight.
|
thanks for the review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #52330 . To be safe, we should keep the previous behavior that resets the
AnalysisContext, in case this is the defaultAnalysisContext(not a fresh one created to analyze a new query) which is kind of a global state.Why are the changes needed?
to avoid potention regressions
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No