[SPARK-52568][BUILD] Fix exec-maven-plugin version used by dev/test-dependencies.sh#51273
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-52568][BUILD] Fix exec-maven-plugin version used by dev/test-dependencies.sh#51273pan3793 wants to merge 1 commit intoapache:masterfrom
exec-maven-plugin version used by dev/test-dependencies.sh#51273pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
…t-dependencies.sh`
dongjoon-hyun
approved these changes
Jun 24, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Nice catch! Thank you, @pan3793 .
| -Dexec.args='${project.version}' \ | ||
| --non-recursive \ | ||
| org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -E '[0-9]+\.[0-9]+\.[0-9]+') | ||
| org.codehaus.mojo:exec-maven-plugin:${MVN_EXEC_PLUGIN_VERSION}:exec | grep -E '[0-9]+\.[0-9]+\.[0-9]+') |
Member
There was a problem hiding this comment.
For the record, the mismatch starts at Apache Spark 3.5.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 25, 2025
…t-dependencies.sh`
### What changes were proposed in this pull request?
Fix `exec-maven-plugin` version used by `dev/test-dependencies.sh` to use the `exec-maven-plugin.version` defined in `pom.xml`, instead of the hardcoded old version(which does not work with Maven 4).
### Why are the changes needed?
Keep toolchain version consistency, and prepare for Maven 4 support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Run `./dev/test-dependencies.sh`
```
...
++ build/mvn help:evaluate -Dexpression=exec-maven-plugin.version -q -DforceStdout
++ grep -E '[0-9]+\.[0-9]+\.[0-9]+'
Using `mvn` from path: /Users/chengpan/Projects/apache-spark/build/apache-maven-3.9.10/bin/mvn
+ MVN_EXEC_PLUGIN_VERSION=3.5.0
+ set +e
++ build/mvn -q -Dexec.executable=echo '-Dexec.args=${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:3.5.0:exec
...
```
And pass GHA.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #51273 from pan3793/SPARK-52568.
Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 36a08bd)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/4.0. Could you make a backporting PR to branch-3.5 too, @pan3793 ? |
pan3793
added a commit
to pan3793/spark
that referenced
this pull request
Jun 26, 2025
…v/test-dependencies.sh`
Fix `exec-maven-plugin` version used by `dev/test-dependencies.sh` to use the `exec-maven-plugin.version` defined in `pom.xml`, instead of the hardcoded old version(which does not work with Maven 4).
Keep toolchain version consistency, and prepare for Maven 4 support.
No.
Run `./dev/test-dependencies.sh`
```
...
++ build/mvn help:evaluate -Dexpression=exec-maven-plugin.version -q -DforceStdout
++ grep -E '[0-9]+\.[0-9]+\.[0-9]+'
Using `mvn` from path: /Users/chengpan/Projects/apache-spark/build/apache-maven-3.9.10/bin/mvn
+ MVN_EXEC_PLUGIN_VERSION=3.5.0
+ set +e
++ build/mvn -q -Dexec.executable=echo '-Dexec.args=${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:3.5.0:exec
...
```
And pass GHA.
No.
Closes apache#51273 from pan3793/SPARK-52568.
Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
@dongjoon-hyun this is for 3.5 #51288 |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 27, 2025
…v/test-dependencies.sh` Cherry-pick #51273 to branch 3.5 ### What changes were proposed in this pull request? Fix `exec-maven-plugin` version used by `dev/test-dependencies.sh` to use the `exec-maven-plugin.version` defined in `pom.xml`, instead of the hardcoded old version(which does not work with Maven 4). ### Why are the changes needed? Keep toolchain version consistency, and prepare for Maven 4 support. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run `./dev/test-dependencies.sh` ``` ... ++ build/mvn help:evaluate -Dexpression=exec-maven-plugin.version -q -DforceStdout ++ grep -E '[0-9]+\.[0-9]+\.[0-9]+' Using `mvn` from path: /Users/chengpan/Projects/apache-spark-3.5/build/apache-maven-3.9.6/bin/mvn + MVN_EXEC_PLUGIN_VERSION=3.1.0 + set +e ++ build/mvn -q -Dexec.executable=echo '-Dexec.args=${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:3.1.0:exec ... ``` And pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51288 from pan3793/SPARK-52568-3.5. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…t-dependencies.sh`
### What changes were proposed in this pull request?
Fix `exec-maven-plugin` version used by `dev/test-dependencies.sh` to use the `exec-maven-plugin.version` defined in `pom.xml`, instead of the hardcoded old version(which does not work with Maven 4).
### Why are the changes needed?
Keep toolchain version consistency, and prepare for Maven 4 support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Run `./dev/test-dependencies.sh`
```
...
++ build/mvn help:evaluate -Dexpression=exec-maven-plugin.version -q -DforceStdout
++ grep -E '[0-9]+\.[0-9]+\.[0-9]+'
Using `mvn` from path: /Users/chengpan/Projects/apache-spark/build/apache-maven-3.9.10/bin/mvn
+ MVN_EXEC_PLUGIN_VERSION=3.5.0
+ set +e
++ build/mvn -q -Dexec.executable=echo '-Dexec.args=${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:3.5.0:exec
...
```
And pass GHA.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#51273 from pan3793/SPARK-52568.
Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 0da8fc5)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
exec-maven-pluginversion used bydev/test-dependencies.shto use theexec-maven-plugin.versiondefined inpom.xml, instead of the hardcoded old version(which does not work with Maven 4).Why are the changes needed?
Keep toolchain version consistency, and prepare for Maven 4 support.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run
./dev/test-dependencies.shAnd pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.