[SPARK-51820][SQL][FOLLOWUP][CONNECT] Don't add UnresolvedOrdinal when appending grouping to aggregate expressions
#50958
+46
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailoale-db
approved these changes
May 20, 2025
vladimirg-db
approved these changes
May 20, 2025
mihailotim-db
force-pushed
the
mihailotim-db/fix_unresolved_ordinal
branch
from
4c2e4f6 to
abc9a0d
Compare
cloud-fan
approved these changes
May 20, 2025
|
thanks, merging to master! |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…hen appending grouping to aggregate expressions ### What changes were proposed in this pull request? Don't add `UnresolvedOrdinal` when appending grouping to aggregate expressions in Spark Connect. ### Why are the changes needed? Change is needed to fix a regression caused by apache#50606 where `UnresolvedOrdinal` would end up in aggregate expression and propagate all the way to `CheckAnalysis` where it would throw an error ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a test case for the correct behavior. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50958 from mihailotim-db/mihailotim-db/fix_unresolved_ordinal. Authored-by: Mihailo Timotic <mihailo.timotic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't add
UnresolvedOrdinalwhen appending grouping to aggregate expressions in Spark Connect.Why are the changes needed?
Change is needed to fix a regression caused by #50606 where
UnresolvedOrdinalwould end up in aggregate expression and propagate all the way toCheckAnalysiswhere it would throw an errorDoes this PR introduce any user-facing change?
No
How was this patch tested?
Added a test case for the correct behavior.
Was this patch authored or co-authored using generative AI tooling?
No.