Skip to content

[SPARK-52218][SQL] Make current datetime functions evaluable again #50936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented May 19, 2025

What changes were proposed in this pull request?

Current date-time functions should only be evaluated all together in the rule FinishAnalysis, so that they have the same consistent value across the entire query plan. To do that we mark current date-time functions as Unevaluable a while ago. Unfortunately, there are still some places that have to evaluate expressions earlier, and the expression may contain current date-time functions. #50800 is one such example.

I think the move to mark these functions as Unevaluable is too aggressive. This PR proposes to revert this restriction to avoid potential regressions. I think the better way forward is to introduce query context to pre-evaluate these current datetime values, and the expressions just get values from the query context and makes sure it produces consistent values during the query life cycle.

Why are the changes needed?

to avoid potential regressions.

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label May 19, 2025
@cloud-fan
Copy link
Contributor Author

cc @MaxGekk @wankunde

Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to adjust CurrentTime:

case class CurrentTime(child: Expression = Literal(TimeType.MICROS_PRECISION))
  extends UnaryExpression with FoldableUnevaluable with ImplicitCastInputTypes {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants