[SPARK-52032][SQL] Fix orc filter pushdown with null-safe equality operator #50932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
LuciferYang
reviewed
May 19, 2025
| @@ -202,6 +202,10 @@ private[sql] object OrcFilters extends OrcFiltersBase { | |||
| val rhs = buildSearchArgument(dataTypeMap, right, lhs) | |||
| rhs.end() | |||
|
|
|||
| case Not(EqualNullSafe(name, value)) if dataTypeMap.contains(name) => | |||
LuciferYang
reviewed
May 19, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
Outdated
Show resolved
Hide resolved
LuciferYang
reviewed
May 19, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Background：As stated in SPARK-52032: When applying a filter using
eqNullSafe(<=>, null-safe equality operator) to a DataFrame created from an ORC file, rows containing null values are incorrectly excluded, even though they should be retained.Changes：1. Added a UT in OrcFilterSuite to reproduce the issue, 2. fix the logic in OrcFilter.
Why are the changes needed?
As stated above, it's an unexpected issue
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT
Was this patch authored or co-authored using generative AI tooling?
No