[SPARK-51745] Enforce State Machine for RocksDBStateStore #50497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
changed the title
ericm-db
changed the title
* [WIP] provider state machine * undoing changes * moving tests, removing unnecessary changes * moving tests back * more unnecessary changes * adding log * this is so dumb * Okay this might be the way to go * let's see this * this is less dumb * removing thread local * adding store.commit() * timer suite * taskCompletionListener -> taskFailureListener * adding assertion that version == readStore.version * fixing more tests * returning same store
* rm acquirelock from rocksdb and move tests * fix tests
ericm-db
force-pushed
the
state-machine-hardening
branch
from
a573cb4 to
253d70b
Compare
…nto state-machine-hardening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces state machine validation to RocksDBStateStore to enforce proper usage patterns. It adds:
The implementation ensures that:
Why are the changes needed?
RocksDBStateStore has implicit usage requirements that weren't being enforced. This could lead to incorrect usage patterns, potential data corruption, and hard-to-debug issues.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests have been added and existing tests modified to validate state transitions and error cases. The PR includes a new test case specifically for SPARK-51596 (unloading only occurs on maintenance thread but occurs promptly).
Was this patch authored or co-authored using generative AI tooling?
No