Revert #48786 - "Revert "[SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier"" #50311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Mar 20, 2025
| import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._ | ||
|
|
||
| val query = Option(ctx.query).map(plan) | ||
| withIdentClause(ctx.identifierReference, query.toSeq, (ident, children) => { |
There was a problem hiding this comment.
can we keep this part? I think it's still better to not hide any plan from PlanWithUnresolvedIdentifier
There was a problem hiding this comment.
@cloud-fan Done.
cloud-fan
approved these changes
Mar 20, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 20, 2025
…ithUnresolvedIdentifier"" ### What changes were proposed in this pull request? This PR reverts #48786 ### Why are the changes needed? Custom rules in the early analyzer batches (custom hint resolution rules injection) can match `UnresolvedRelation`, which is only visible after the IDENTIFIER clause is expanded. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests + added a unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50311 from dusantism-db/identifier-revert. Authored-by: Dušan Tišma <dusan.tisma@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 7dfb8fe) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts #48786
Why are the changes needed?
Custom rules in the early analyzer batches (custom hint resolution rules injection) can match
UnresolvedRelation, which is only visible after the IDENTIFIER clause is expanded.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests + added a unit test.
Was this patch authored or co-authored using generative AI tooling?
No.