[SPARK-51544][SQL] Add only unique and necessary metadata columns #50304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailotim-db
force-pushed
the
mihailotim-db/unique_metadata_cols
branch
4 times, most recently
from
70f521d to
ba26f39
Compare
mihailotim-db
changed the title
mihailotim-db
force-pushed
the
mihailotim-db/unique_metadata_cols
branch
2 times, most recently
from
55e5cb8 to
cb0223a
Compare
cloud-fan
reviewed
Mar 19, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 19, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 19, 2025
| case attr | ||
| if requiredAttrIds.contains(attr.exprId) && !existingExprIds | ||
| .contains(attr.exprId) => | ||
| existingExprIds.add(attr.exprId) |
There was a problem hiding this comment.
given we won't have duplicated expr IDs within metadata columns, do we really need to update this ID set here?
There was a problem hiding this comment.
We never actually guarantee that we won't have duplicate ExprIds in metadata output, we just inherit from below and append the new ones. Maybe instead of enforcing this here, we should enforce uniqueness when creating metadata?
cloud-fan
reviewed
Mar 19, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Show resolved
Hide resolved
mihailotim-db
force-pushed
the
mihailotim-db/unique_metadata_cols
branch
from
cb0223a to
076cb67
Compare
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AddMetadataColumns should add only unique and necessary metadata columns, not the entire child's metadata output
Why are the changes needed?
There are 3 reasons to make this change:
AddMetadataColumnsandResolveReferencescan add same attributes.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a new suite to test
AddMetadataColumnsrule. Existing testsWas this patch authored or co-authored using generative AI tooling?
No