[SPARK-6330] Fix filesystem bug in newParquet relation #5020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,6 +262,7 @@ private[sql] case class ParquetRelation2( | |||
|
|
|||
| // Lists `FileStatus`es of all leaf nodes (files) under all base directories. | |||
| val leaves = baseStatuses.flatMap { f => | |||
| val fs = FileSystem.get(URI.create(f.getPath.toString), sparkContext.hadoopConfiguration) | |||
There was a problem hiding this comment.
If f here is a FileStatus, then I think you can do f.getPath.toUri, perhaps?
|
Test build #28592 has started for PR 5020 at commit
|
|
Test build #28594 has started for PR 5020 at commit
|
|
LGTM, thanks! |
|
Test build #28592 has finished for PR 5020 at commit
|
|
Test PASSed. |
|
Test build #28594 has finished for PR 5020 at commit
|
|
Test PASSed. |
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2015
If I'm running this locally and my path points to S3, this would currently error out because of incorrect FS. I tested this in a scenario that previously didn't work, this change seemed to fix the issue. Author: Volodymyr Lyubinets <vlyubin@gmail.com> Closes #5020 from vlyubin/parquertbug and squashes the following commits: a645ad5 [Volodymyr Lyubinets] Fix filesystem bug in newParquet relation
|
Merged into master and branch-1.3, thanks! |
christopherbozeman
pushed a commit
to christopherbozeman/spark
that referenced
this pull request
Mar 25, 2015
If I'm running this locally and my path points to S3, this would currently error out because of incorrect FS. I tested this in a scenario that previously didn't work, this change seemed to fix the issue. Author: Volodymyr Lyubinets <vlyubin@gmail.com> Closes apache#5020 from vlyubin/parquertbug and squashes the following commits: a645ad5 [Volodymyr Lyubinets] Fix filesystem bug in newParquet relation
mingyukim
pushed a commit
to palantir/spark
that referenced
this pull request
Mar 27, 2015
If I'm running this locally and my path points to S3, this would currently error out because of incorrect FS. I tested this in a scenario that previously didn't work, this change seemed to fix the issue. Author: Volodymyr Lyubinets <vlyubin@gmail.com> Closes apache#5020 from vlyubin/parquertbug and squashes the following commits: a645ad5 [Volodymyr Lyubinets] Fix filesystem bug in newParquet relation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm running this locally and my path points to S3, this would currently error out because of incorrect FS.
I tested this in a scenario that previously didn't work, this change seemed to fix the issue.