Skip to content

[SPARK-6285] [SQL] Removes unused ParquetTestData and duplicated TestGroupWriteSupport #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-6285] [SQL] Removes unused ParquetTestData and duplicated TestGroupWriteSupport #5010

wants to merge 1 commit into from

Conversation

liancheng
Copy link
Contributor

All the contents in this file are not referenced anywhere and should have been removed in #4116 when I tried to get rid of the old Parquet test suites.

Review on Reviewable

@SparkQA
Copy link

SparkQA commented Mar 13, 2015

Test build #28559 has started for PR 5010 at commit 06ed057.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Mar 13, 2015

LGTM, go for it if Jenkins succeeds.

@SparkQA
Copy link

SparkQA commented Mar 13, 2015

Test build #28559 has finished for PR 5010 at commit 06ed057.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28559/
Test FAILed.

@srowen
Copy link
Member

srowen commented Mar 13, 2015

jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Mar 13, 2015

Test build #28563 has started for PR 5010 at commit 06ed057.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 13, 2015

Test build #28563 has finished for PR 5010 at commit 06ed057.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28563/
Test PASSed.

@liancheng
Copy link
Contributor Author

@srowen Thanks for the review! Gonna merge this into master and branch-1.3

@asfgit asfgit closed this in cdc34ed Mar 13, 2015
@liancheng
Copy link
Contributor Author

Actually I'm not quite sure whether this should be backported to branch-1.3 at this moment, merged to master only for safe. @pwendell?

@srowen
Copy link
Member

srowen commented Mar 13, 2015

This is more of a cleanup and improvement than bug fix. Although it can affect the build in some contexts, it does not affect the build of reference. Generally I think of improvements as things that are not back-ported unless they are large, important improvements. So I think it's safe to just merge to master, IMHO.

@liancheng liancheng deleted the spark-6285 branch March 14, 2015 11:52
@OopsOutOfMemory OopsOutOfMemory mentioned this pull request Mar 15, 2015
Closed
asfgit pushed a commit that referenced this pull request Mar 15, 2015
@OopsOutOfMemory @liancheng
[SPARK-6285][SQL]Remove ParquetTestData in SparkBuild.scala and in RE…
62ede53 
…ADME.md

This is a following clean up PR for #5010
This will resolve issues when launching `hive/console` like below:
```
<console>:20: error: object ParquetTestData is not a member of package org.apache.spark.sql.parquet
       import org.apache.spark.sql.parquet.ParquetTestData
```

Author: OopsOutOfMemory <victorshengli@126.com>

Closes #5032 from OopsOutOfMemory/SPARK-6285 and squashes the following commits:

2996aeb [OopsOutOfMemory] remove ParquetTestData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liancheng @SparkQA @srowen @AmplabJenkins