[SPARK-51187][SQL][SS][3.5] Implement the graceful deprecation of incorrect config introduced in SPARK-49699 #49985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making this PR, @HeartSaVioR . I sent an email for further discussion. |
dongjoon-hyun
approved these changes
Feb 19, 2025
dongjoon-hyun
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Oh, could you the old config to deprecatedSQLConfigs, @HeartSaVioR , please?
There was a problem hiding this comment.
The vote passed. Could you address the above review comment, @HeartSaVioR ?
|
@dongjoon-hyun I've pushed the commit 673f789 to reflect your feedback. Would you mind having a review again? Thanks! |
|
Thank you! Sure, @HeartSaVioR . |
| @@ -4480,7 +4481,9 @@ object SQLConf { | |||
| DeprecatedConfig(LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED.key, "3.2", | |||
| """Use `.format("avro")` in `DataFrameWriter` or `DataFrameReader` instead."""), | |||
| DeprecatedConfig(COALESCE_PARTITIONS_MIN_PARTITION_NUM.key, "3.2", | |||
| s"Use '${COALESCE_PARTITIONS_MIN_PARTITION_SIZE.key}' instead.") | |||
| s"Use '${COALESCE_PARTITIONS_MIN_PARTITION_SIZE.key}' instead."), | |||
| DeprecatedConfig(PRUNE_FILTERS_CAN_PRUNE_STREAMING_SUBPLAN.alternatives.head, "3.5.4", | |||
There was a problem hiding this comment.
According to the definition, this should be 3.5.5.
Version of Spark where key was deprecated.
There was a problem hiding this comment.
Sorry was confused. Nice finding!
dongjoon-hyun
approved these changes
Feb 23, 2025
|
I verified the deprecation warning messages. Thank you again. |
|
The very previous commit passed the CI and the last commit is only to change the version number string to Let me merge this. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 23, 2025
…orrect config introduced in SPARK-49699 ### What changes were proposed in this pull request? This PR proposes to implement the graceful deprecation of incorrect config introduced in SPARK-49699. SPARK-49699 was included in Spark 3.5.4, hence we can't simply rename to fix the issue. Also, since the incorrect config is logged in offset log in streaming query, the fix isn't just easy like adding withAlternative and done. We need to manually handle the case where offset log contains the incorrect config, and set the value of incorrect config in the offset log into the new config. Once a single microbatch has planned after the restart (hence the above logic is applied), offset log will contain the "new" config and it will no longer refer to the incorrect config. That said, we can remove the incorrect config in the Spark version which we are confident that there will be no case users will upgrade from Spark 3.5.4 to that version. ### Why are the changes needed? We released an incorrect config and we want to rename it properly. While renaming, we don't also want to have any breakage on the existing streaming query. ### Does this PR introduce _any_ user-facing change? No. That is what this PR is aiming for. ### How was this patch tested? New UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49985 from HeartSaVioR/SPARK-51187-3.5. Authored-by: Jungtaek Lim <kabhwan.opensource@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to branch-3.5. |
|
Thank you, @HeartSaVioR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to implement the graceful deprecation of incorrect config introduced in SPARK-49699.
SPARK-49699 was included in Spark 3.5.4, hence we can't simply rename to fix the issue.
Also, since the incorrect config is logged in offset log in streaming query, the fix isn't just easy like adding withAlternative and done. We need to manually handle the case where offset log contains the incorrect config, and set the value of incorrect config in the offset log into the new config. Once a single microbatch has planned after the restart (hence the above logic is applied), offset log will contain the "new" config and it will no longer refer to the incorrect config.
That said, we can remove the incorrect config in the Spark version which we are confident that there will be no case users will upgrade from Spark 3.5.4 to that version.
Why are the changes needed?
We released an incorrect config and we want to rename it properly. While renaming, we don't also want to have any breakage on the existing streaming query.
Does this PR introduce any user-facing change?
No. That is what this PR is aiming for.
How was this patch tested?
New UT.
Was this patch authored or co-authored using generative AI tooling?
No.