Skip to content

[MINOR][SQL][TESTS] Remove redundant space at PropagateEmptyRelationSuite class definition #49911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

WweiL
Copy link
Contributor

@WweiL WweiL commented Feb 12, 2025

What changes were proposed in this pull request?

Followup of #48149, minor minor style fix

Why are the changes needed?

Style

Does this PR introduce any user-facing change?

No

How was this patch tested?

As long as it compiles

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Feb 12, 2025
@WweiL
Copy link
Contributor Author

WweiL commented Feb 12, 2025

Probably not needed to go to 3.5..

@dongjoon-hyun dongjoon-hyun changed the title [MINOR] Style fix [MINOR][SQL][TESTS] Style fix Feb 12, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, could you check if there are more instances like this, @WweiL ?

@dongjoon-hyun
Copy link
Member

BTW, are you sure about this, @WweiL ? For me, this looks like a wrong claim.

Screenshot 2025-02-12 at 11 38 12

@WweiL
Copy link
Contributor Author

WweiL commented Feb 13, 2025

@dongjoon-hyun I checked again the original PR and everything else seems fine. I also searched if there were some other occurrence of "class " and didn't find more occurrence.

I also changed the pr in the link to the original PR. PTAL!

@WweiL WweiL requested a review from dongjoon-hyun February 13, 2025 00:28
@dongjoon-hyun dongjoon-hyun changed the title [MINOR][SQL][TESTS] Style fix [MINOR][SQL][TESTS] Remove redundant space at PropagateEmptyRelationSuite class definition Feb 13, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @WweiL .
Merged to master.

@WweiL WweiL deleted the minor branch February 13, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants