[SPARK-49273][CONNECT][SQL] Origin support for Spark Connect Scala client #49373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/KeyValueGroupedDatasetE2ETestSuite.scala
xupefei
changed the title
…ster' of github.com:apache/spark into connect-origin # Conflicts: # python/pyspark/sql/connect/proto/common_pb2.py # python/pyspark/sql/connect/proto/common_pb2.pyi # sql/connect/common/src/main/protobuf/spark/connect/common.proto # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName.json # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName.proto.bin # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName_descFilePath.json # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName_descFilePath.proto.bin # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName_descFilePath_options.json # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName_descFilePath_options.proto.bin # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName_options.json # sql/connect/common/src/test/resources/query-tests/queries/to_protobuf_messageClassName_options.proto.bin
HyukjinKwon
approved these changes
Jan 19, 2025
HyukjinKwon
changed the title
|
Merged to master and branch-4.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 19, 2025
…ient This PR adds support for `Origin` to the Scala client of Spark Connect. The approach is to send the client `Origin` instance over the wire to the Server, which will reconstruct the instance and attach it to the expression during transformation. By default, only the last element in the stack trace is sent to the server. This is in line with the Python implementation and can be controlled via a Spark config `spark.sql.stackTracesInDataFrameContext`. One Origin message can contain only one of `PythonOrigin` and `JvmOrigin`. The former is filled by the Python client (#46789) and the latter by the Scala client (this PR). Close the gap between Classic & Connect. No. New tests. Yes, to generate protobuf messages. Closes #49373 from xupefei/connect-origin. Authored-by: Paddy Xu <xupaddy@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit c7df014) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support for
Originto the Scala client of Spark Connect.The approach is to send the client
Origininstance over the wire to the Server, which will reconstruct the instance and attach it to the expression during transformation. By default, only the last element in the stack trace is sent to the server. This is in line with the Python implementation and can be controlled via a Spark configspark.sql.stackTracesInDataFrameContext.One Origin message can contain only one of
PythonOriginandJvmOrigin. The former is filled by the Python client (#46789) and the latter by the Scala client (this PR).Why are the changes needed?
Close the gap between Classic & Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests.
Was this patch authored or co-authored using generative AI tooling?
Yes, to generate protobuf messages.