[SPARK-50526][SS] Add store encoding format conf into offset log and block non supported stateful operators from using avro #49121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k non supported stateful operators from using avro
|
cc - @ericm-db @HeartSaVioR - PTAL, thx ! |
ericm-db
approved these changes
Dec 10, 2024
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingDeduplicationSuite.scala
Show resolved
Hide resolved
HeartSaVioR
reviewed
Dec 12, 2024
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateChainingSuite.scala
Outdated
Show resolved
Hide resolved
...lyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingDeduplicationSuite.scala
Outdated
Show resolved
Hide resolved
Done - added the test |
|
Thanks! Merging to master. |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 12, 2025
### What changes were proposed in this pull request? This PR aims to add `configName` Scalastyle rule to prevent invalid config names. ### Why are the changes needed? To prevent repetitive mistake pattern - #45649 - #48149 - #49121 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Currently, this PR will fail at Scalastyle test because the `master` branch is broken. We can merge this after the following PR. - #49897 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49900 from dongjoon-hyun/SPARK-51173. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 12, 2025
### What changes were proposed in this pull request? This PR aims to add `configName` Scalastyle rule to prevent invalid config names. ### Why are the changes needed? To prevent repetitive mistake pattern - #45649 - #48149 - #49121 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Currently, this PR will fail at Scalastyle test because the `master` branch is broken. We can merge this after the following PR. - #49897 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49900 from dongjoon-hyun/SPARK-51173. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 274dc5e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 23, 2025
This PR aims to add `configName` Scalastyle rule to prevent invalid config names. To prevent repetitive mistake pattern - #45649 - #48149 - #49121 No. Currently, this PR will fail at Scalastyle test because the `master` branch is broken. We can merge this after the following PR. - #49897 No. Closes #49900 from dongjoon-hyun/SPARK-51173. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 274dc5e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add store encoding format conf into offset log and block non supported stateful operators from using avro
Why are the changes needed?
Changes are needed to ensure that encoding format info is stored in offset log and that trying to use avro in a query that has stateful operators that don't support this encoding format yet will result in query failure.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Added unit tests
Was this patch authored or co-authored using generative AI tooling?
No