[SPARK-49951][SQL] Assign proper error condition for _LEGACY_ERROR_TEMP_(1099|3085) #48449
+44
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
commented
Oct 14, 2024
Comment on lines
110
to
121
| checkError( | ||
| exception = intercept[AnalysisException] { | ||
| avroStructDF.select( | ||
| functions.from_avro( | ||
| $"avro", avroTypeStruct, Map("mode" -> "DROPMALFORMED").asJava)).collect() | ||
| }, | ||
| condition = "PARSE_MODE_UNSUPPORTED", | ||
| parameters = Map( | ||
| "funcName" -> "from_avro", | ||
| "mode" -> "DROPMALFORMED", | ||
| "permissiveMode" -> "PERMISSIVE", | ||
| "failFastMode" -> "FAILFAST")) |
There was a problem hiding this comment.
Added new test for _LEGACY_ERROR_TEMP_3085
cc @MaxGekk fyi
MaxGekk
requested changes
Oct 14, 2024
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Oct 16, 2024
| @@ -1341,12 +1341,10 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat | |||
|
|
|||
| def parseModeUnsupportedError(funcName: String, mode: ParseMode): Throwable = { | |||
| new AnalysisException( | |||
| errorClass = "_LEGACY_ERROR_TEMP_1099", | |||
| errorClass = "PARSE_MODE_UNSUPPORTED", | |||
| messageParameters = Map( | |||
| "funcName" -> funcName, | |||
There was a problem hiding this comment.
Since it is an id, please, quote it:
Suggested change
| "funcName" -> funcName, | |
| "funcName" -> toSQLId(funcName), |
| "permissiveMode" -> PermissiveMode.name, | ||
| "failFastMode" -> FailFastMode.name)) | ||
| throw QueryCompilationErrors.parseModeUnsupportedError( | ||
| "from_avro", parseMode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign proper error condition & sqlstate for LEGACY_ERROR_TEMP(1099|3085)
Why are the changes needed?
To improve the error message by assigning proper error condition and SQLSTATE
Does this PR introduce any user-facing change?
No, only user-facing error message improved
How was this patch tested?
Updated the existing tests
Was this patch authored or co-authored using generative AI tooling?
No