[SPARK-49937][INFRA] Ban call the method SparkThrowable#getErrorClass
#48426
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual verification is as follows:
|
panbingkun
commented
Oct 12, 2024
| @@ -1621,7 +1621,7 @@ class PreemptedError() { | |||
| // errors have the lowest priority. | |||
| def set(error: Exception with SparkThrowable, priority: Option[Int] = None): Unit = { | |||
| val calculatedPriority = priority.getOrElse { | |||
| error.getCondition match { | |||
| error.getErrorClass match { | |||
There was a problem hiding this comment.
Further validation will be double-checked on GA as follows:
https://github.com/panbingkun/spark/actions/runs/11303132501/job/31439885127
|
Whether we can only ban calls to |
HyukjinKwon
approved these changes
Oct 12, 2024
MaxGekk
approved these changes
Oct 12, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to ban call the method
SparkThrowable#getErrorClass.Why are the changes needed?
After PR #48196,
SparkThrowable#getErrorClasshas been marked asDeprecated. In order to prevent future developers from callingSparkThrowable#getErrorClassagain, which may require continuous fix and migration, callingSparkThrowable#getErrorClassis strictly prohibited as it will fail at the compilation level.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.